From owner-svn-src-head@freebsd.org Fri Mar 15 17:04:34 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15E9A1526F8C; Fri, 15 Mar 2019 17:04:34 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8A38E71488; Fri, 15 Mar 2019 17:04:33 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x2FH4V0U031150; Fri, 15 Mar 2019 10:04:31 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x2FH4URq031149; Fri, 15 Mar 2019 10:04:30 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201903151704.x2FH4URq031149@gndrsh.dnsmgr.net> Subject: Re: svn commit: r345151 - head/sys/net In-Reply-To: <51089C2A-A135-445E-B733-02654C5F8B68@lists.zabbadoz.net> To: "Bjoern A. Zeeb" Date: Fri, 15 Mar 2019 10:04:30 -0700 (PDT) CC: Kyle Evans , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 8A38E71488 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.93)[-0.926,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 17:04:34 -0000 > On 14 Mar 2019, at 19:48, Kyle Evans wrote: > > > Author: kevans > > Date: Thu Mar 14 19:48:43 2019 > > New Revision: 345151 > > URL: https://svnweb.freebsd.org/changeset/base/345151 > > > > Log: > > ether_fakeaddr: Use 'b' 's' 'd' for the prefix > > > > This has the advantage of being obvious to sniff out the designated > > prefix > > by eye and it has all the right bits set. Comment stolen from ffec. > > > > I've removed bryanv@'s pending question of using the FreeBSD OUI > > range -- > > no one has followed up on this with a definitive action, and there's > > no > > particular reason to shoot for it and the administrative overhead > > that comes > > with deciding exactly how to use it. > > Yay. iflib_gen_mac() has already thought kind-of similar and just took > the entire(?) FreeBSD space for doing the same. That code should be > merged as well. > > Bhyve is using a good chunk from the FreeBSD allocation; see > sys/net/ieee_oui.h also for allocation guidelines (if I don?t > misremember). > > The fact that it might need figuring out should not prevent us from > doing it right .. the third time .. maybe .. this time? > > epair(4) is yet another one of the cloned interfaces which does magic > for the ethernet addresses, not sure what else. Yes yes yes please! Can we get the OUI assigning code collapsed to one place, though it well need to come in dependent on a complex set of options, or perhaps just INET and/or INET6 should drag it in. Thanks to anyone that does this work! > /bz -- Rod Grimes rgrimes@freebsd.org