From nobody Tue Jun 2 07:26:24 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gV2Sd2sTGz6f8fW for ; Tue, 02 Jun 2026 07:26:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gV2Sc5PMyz3mpS for ; Tue, 02 Jun 2026 07:26:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780385184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=khBwSy/AhEq3CX8Ezs4tGAmu6GTrJm7s+pAyFMhE1KY=; b=FNH6lMDh6UH7SY0afuSB88oq2JOtzyVO7nEqNs7bSkLO9sLr1K1cEDa1Rp0BWH90SG7waD 93Gr62JLLZH+87Nh8lbqKvIQWT6BLvNaAFHELKnlB0bnZ0D1VNdEN4ImBnIAI8z5XDR1s5 AWWqpdNW/Y5njmKUHyDf2/rKkCtc/7NgSZNVlGg20kUu3QBwt0kpjcq+0/HQZytp74X6/U bdI5/XMfeI5FJaOD0ssJbRZxk8/ibFEldQYHRzWsEC1+RMywSwcIDpImKN9CKBXGx5TmFk haY6mjyagnMr8vt+h2b7H6ra2QtyfHuIQm6kUF4ZIPScmBkrKidvnajUb/nvZw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780385184; a=rsa-sha256; cv=none; b=f8NoobRpqusDFJSoBYnytpbBGTvuncHaejZjWZw59tgQgscr4QQJsOse6U9nqu5aOiOKy6 paKjQ1CjUaPRWb+Hr6Wl6DoMHM/7+rVJYG5YcVv0xwraH+r53ZVzsWTJcQqZ/a+lYAVTJH kyz6bwNZjwbkzcj+LHzq5my0K0nHBQ12Z45e0/YrcBgt046FYkPUWzdO/T5bhp3dEkpYzt y9GxW6ZxdmSeCY5H8KdQPJ6akhAqyqaFilxJfcVp6fZiP+cJLwwsq7G0eSWsb4Us1I13Ih m3MOWrxKGetJjfc3g6AiMWfXElWiauPhiz9DBqop2S+66JXRRITe0GpFzD5OtQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780385184; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=khBwSy/AhEq3CX8Ezs4tGAmu6GTrJm7s+pAyFMhE1KY=; b=mKprK1J9XqgaJaVQFApASMp6dFHXXqi1XGLW7yZcjXeQFbMIiLeO9DK6bzIGcZxi94eLHc 2SIlU8iaUwURMqHmXO7+NEOGbiSC9Bemuk0o2WqancWWQ1WAJIcH0GfFFjSK9QEtFh0f5d 8dsIFBXsSmYeSGVT4OP0XuckoCecOdl2vxf1Jysf2ugHqRnVHOMtVAEqugP8JOfCw5BImc +SKCYVucoR3NiCmcxCemeFeQlzYLCn3scoSrlCJHBrm0gerq58Tbufgb/y/WNHixUJamGE KTF1AGKnr1Cr26CoicB3nazomcg7Ur8+B9oapQSDcaJQotyDJpk2VPZQbDKfDw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gV2Sc4GgTz126 for ; Tue, 02 Jun 2026 07:26:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21f2c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 02 Jun 2026 07:26:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Ricardo Branco From: Pouria Mousavizadeh Tehrani Subject: git: c515e6040614 - main - linux: Implement PTRACE_GETREGSET NT_PRFPREG and NT_X86_XSTATE List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pouria X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c515e6040614434a9262ee8b5ac54b81476ec7ff Auto-Submitted: auto-generated Date: Tue, 02 Jun 2026 07:26:24 +0000 Message-Id: <6a1e85a0.21f2c.479eced8@gitrepo.freebsd.org> The branch main has been updated by pouria: URL: https://cgit.FreeBSD.org/src/commit/?id=c515e6040614434a9262ee8b5ac54b81476ec7ff commit c515e6040614434a9262ee8b5ac54b81476ec7ff Author: Ricardo Branco AuthorDate: 2026-04-26 14:45:35 +0000 Commit: Pouria Mousavizadeh Tehrani CommitDate: 2026-06-02 07:25:37 +0000 linux: Implement PTRACE_GETREGSET NT_PRFPREG and NT_X86_XSTATE Implement NT_PRFPREG and NT_X86_XSTATE for PTRACE_GETREGSET on amd64. Chrome's crashpad handler uses these to collect floating-point and extended CPU register state for crash dumps. Other architectures retain the previous EINVAL stub behavior. Signed-off-by: Ricardo Branco PR: 289285 Reviewed by: kib Pull-Request: https://github.com/freebsd/freebsd-src/pull/2165 --- sys/compat/linux/linux_ptrace.c | 91 ++++++++++++++++++++++++++++++++++++++--- 1 file changed, 85 insertions(+), 6 deletions(-) diff --git a/sys/compat/linux/linux_ptrace.c b/sys/compat/linux/linux_ptrace.c index 0dbfd2177122..28a4c42190af 100644 --- a/sys/compat/linux/linux_ptrace.c +++ b/sys/compat/linux/linux_ptrace.c @@ -335,6 +335,87 @@ linux_ptrace_getregset_prstatus(struct thread *td, pid_t pid, l_ulong data) return (error); } +#ifdef __amd64__ +static int +linux_ptrace_getregset_prfpreg(struct thread *td, pid_t pid, l_ulong data) +{ + struct fpreg b_fpreg; + struct linux_pt_fpregset l_fpregset; + struct iovec iov; + size_t len; + int error; + + error = copyin((const void *)data, &iov, sizeof(iov)); + if (error != 0) { + linux_msg(td, "copyin error %d", error); + return (error); + } + + error = kern_ptrace(td, PT_GETFPREGS, pid, &b_fpreg, 0); + if (error != 0) + return (error); + + bsd_to_linux_fpregset(&b_fpreg, &l_fpregset); + + len = MIN(iov.iov_len, sizeof(l_fpregset)); + error = copyout(&l_fpregset, iov.iov_base, len); + if (error != 0) { + linux_msg(td, "copyout error %d", error); + return (error); + } + + iov.iov_len = len; + error = copyout(&iov, (void *)data, sizeof(iov)); + if (error != 0) + linux_msg(td, "iov copyout error %d", error); + + return (error); +} + +static int +linux_ptrace_getregset_xstate(struct thread *td, pid_t pid, l_ulong data) +{ + struct ptrace_xstate_info info; + struct iovec iov; + void *xstate; + size_t len; + int error; + + error = copyin((const void *)data, &iov, sizeof(iov)); + if (error != 0) { + linux_msg(td, "copyin error %d", error); + return (error); + } + + error = kern_ptrace(td, PT_GETXSTATE_INFO, pid, &info, sizeof(info)); + if (error != 0) + return (error); + + xstate = malloc(info.xsave_len, M_LINUX, M_WAITOK | M_ZERO); + + error = kern_ptrace(td, PT_GETXSTATE, pid, xstate, info.xsave_len); + if (error != 0) { + free(xstate, M_LINUX); + return (error); + } + + len = MIN(iov.iov_len, info.xsave_len); + error = copyout(xstate, iov.iov_base, len); + free(xstate, M_LINUX); + if (error != 0) { + linux_msg(td, "copyout error %d", error); + return (error); + } + + iov.iov_len = len; + error = copyout(&iov, (void *)data, sizeof(iov)); + if (error != 0) + linux_msg(td, "iov copyout error %d", error); + + return (error); +} +#endif /* __amd64__ */ + static int linux_ptrace_getregset(struct thread *td, pid_t pid, l_ulong addr, l_ulong data) { @@ -342,14 +423,12 @@ linux_ptrace_getregset(struct thread *td, pid_t pid, l_ulong addr, l_ulong data) switch (addr) { case LINUX_NT_PRSTATUS: return (linux_ptrace_getregset_prstatus(td, pid, data)); +#ifdef __amd64__ case LINUX_NT_PRFPREG: - linux_msg(td, "PTRAGE_GETREGSET NT_PRFPREG not implemented; " - "returning EINVAL"); - return (EINVAL); + return (linux_ptrace_getregset_prfpreg(td, pid, data)); case LINUX_NT_X86_XSTATE: - linux_msg(td, "PTRAGE_GETREGSET NT_X86_XSTATE not implemented; " - "returning EINVAL"); - return (EINVAL); + return (linux_ptrace_getregset_xstate(td, pid, data)); +#endif default: linux_msg(td, "PTRACE_GETREGSET request %#lx not implemented; " "returning EINVAL", addr);