From owner-freebsd-mips@freebsd.org Thu Feb 4 15:59:17 2016 Return-Path: Delivered-To: freebsd-mips@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD729A9BFE0 for ; Thu, 4 Feb 2016 15:59:17 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from phabric-backend.rbsd.freebsd.org (unknown [IPv6:2607:fc50:2000:101::1bb:73]) by mx1.freebsd.org (Postfix) with ESMTP id 9B48A34E for ; Thu, 4 Feb 2016 15:59:17 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by phabric-backend.rbsd.freebsd.org (Postfix, from userid 1346) id 989091071B6; Thu, 4 Feb 2016 15:59:17 +0000 (UTC) Date: Thu, 4 Feb 2016 15:59:17 +0000 To: freebsd-mips@freebsd.org From: "kan (Alexander Kabaev)" Reply-to: D5182+328+d50d24cb3b48f0f7@reviews.freebsd.org Subject: [Differential] [Requested Changes To] D5182: Introduce INTRNG support for MIPS Message-ID: <962cfb9cf8abde906df9b439307ea44a@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , Thread-Topic: D5182: Introduce INTRNG support for MIPS X-Herald-Rules: <28> X-Phabricator-Projects: <#mips> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTNiZTMzOTczYThlNTY2OTc3Njk3NGIyZTc5IFazdVU= MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2016 15:59:17 -0000 kan requested changes to this revision. kan added a comment. This revision now requires changes to proceed. I do not see mips_pic.c in this patch, which is supposed to the the generic MIPS32 intr controller and is the place where cpu_establish_hard_intr for INTRNG is implemented. If you do not need rest of the mips_pic.c, consider moving these into an independent implementation file (mips/mips/intr.c?). You will need to export the root PIC pointer from MI intr code for that and that is the reason why I kept function in the file that implements root PIC on my SOC. INLINE COMMENTS sys/mips/include/intr.h:95 Because unifying .h files as declared as TODO by adrian and he is still on the hook to do it some day, I hope. sys/mips/mips/nexus.c:424 This bit is unrelated to INTRNG really, is it not? We should be able to avoid dragging it into -current only to be replaced later by fdtbus_bs_tag removal patch. sys/mips/mips/nexus.c:454 Same here. sys/mips/mips/nexus.c:605 This bit is also not an INTRNG piece, but rather a separate change than has an implication of enabling bus passes on the whole MIPS platform and as such probably deserves a separate commit. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D5182 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: Sgalabov_gmail.com, MIPS, adrian, kan Cc: skra, imp, freebsd-mips-list