From owner-svn-src-all@FreeBSD.ORG Fri Sep 3 06:24:22 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9B4C5106578C; Fri, 3 Sep 2010 06:24:22 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id E74848FC0A; Fri, 3 Sep 2010 06:24:10 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 9BA3645C8C; Fri, 3 Sep 2010 08:24:09 +0200 (CEST) Received: from localhost (pdawidek.whl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id ABDC045685; Fri, 3 Sep 2010 08:24:04 +0200 (CEST) Date: Fri, 3 Sep 2010 08:23:55 +0200 From: Pawel Jakub Dawidek To: "Justin T. Gibbs" Message-ID: <20100903062355.GB1780@garage.freebsd.pl> References: <201009021940.o82JeS8M017537@svn.freebsd.org> <20100902213926.GA2542@garage.freebsd.pl> <4C802028.4040400@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pvezYHf7grwyp3Bc" Content-Disposition: inline In-Reply-To: <4C802028.4040400@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r212160 - in head/sys: cam/ata cam/scsi cddl/contrib/opensolaris/uts/common/fs/zfs geom geom/sched kern sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2010 06:24:22 -0000 --pvezYHf7grwyp3Bc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 02, 2010 at 04:07:36PM -0600, Justin T. Gibbs wrote: > On 9/2/2010 3:39 PM, Pawel Jakub Dawidek wrote: > > Don't you think it would be better to set the flag from within > > g_io_request()? This way every BIO_FLUSH consumer doesn't have to > > remember to set it. Or am I missing something? >=20 > I don't feel strongly one way or the other, but I thought that > g_io_request()'s job was to execute the request and to test invariants, > not to set policy. Perhaps I misinterpreted it's role. Does BIO_FLUSH make sense without BIO_ORDERED? My understanding is that it doesn't. But we still want BIO_ORDERED for use with BIO_WRITE for write barriers without cache flushing. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --pvezYHf7grwyp3Bc Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkyAlHsACgkQForvXbEpPzRCZwCg1/3tHQmYuao+m9qF9Nvj2jbH 1DIAn3unwLCsDxs5fiyrOYDeOSHbOl4d =dskq -----END PGP SIGNATURE----- --pvezYHf7grwyp3Bc--