From owner-freebsd-current@freebsd.org Wed Dec 2 07:39:18 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6C44FA3EF57 for ; Wed, 2 Dec 2015 07:39:18 +0000 (UTC) (envelope-from jean-sebastien.pedron@dumbbell.fr) Received: from mail.made4.biz (mail.made4.biz [IPv6:2001:41d0:2:c018::1:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2AA7114A7 for ; Wed, 2 Dec 2015 07:39:18 +0000 (UTC) (envelope-from jean-sebastien.pedron@dumbbell.fr) Received: from 141.7.19.93.rev.sfr.net ([93.19.7.141] helo=magellan.dumbbell.fr) by mail.made4.biz with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.86 (FreeBSD)) (envelope-from ) id 1a420R-0006nk-M2 for freebsd-current@freebsd.org; Wed, 02 Dec 2015 08:39:15 +0100 Subject: Re: EFI and i915kms questions To: freebsd-current@freebsd.org References: <54B18FFE-063F-4F62-9343-28FDE68EE358@pcbsd.org> <56505B3F.2070403@dumbbell.fr> <5BC149BC-8BA6-4089-A9E6-763E2494A30A@pcbsd.org> <1736392.rQjToYj3It@ralph.baldwin.cx> From: =?UTF-8?Q?Jean-S=c3=a9bastien_P=c3=a9dron?= X-Enigmail-Draft-Status: N1110 Message-ID: <565EA01E.7000300@dumbbell.fr> Date: Wed, 2 Dec 2015 08:39:10 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1736392.rQjToYj3It@ralph.baldwin.cx> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uaeuxgrhrIB2nxxjinPocCordRdhJBBak" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 07:39:18 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uaeuxgrhrIB2nxxjinPocCordRdhJBBak Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/12/2015 02:00, John Baldwin wrote: > Note that at the top of the function it invokes IICBUS_TRANSFER on a di= fferent > device when force_bit_dev is true: >=20 > 370 sx_xlock(&dev_priv->gmbus_sx); > 371 if (sc->force_bit_dev) { > 372 dumbbell 282199 error =3D -IICBUS_TRANSFER(dev_p= riv->bbbus[unit], msgs, nmsgs); > 373 kib 235783 goto out; > 374 } >=20 > Hmm, I would try changing the line at 470 to match the line at 372. >=20 > They used to match, and then this change: You're right. This is something I fixed in my i915 update branch but forgot to commit to HEAD... Joe, could you please try what John suggests to confirm? --=20 Jean-S=C3=A9bastien P=C3=A9dron --uaeuxgrhrIB2nxxjinPocCordRdhJBBak Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJWXqAjXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NzA4N0ZEMUFFQUUwRTEyREJDNkE2RjAz OUU5OTc2MUE1RkQ5NENDAAoJEDnpl2Gl/ZTMQsUP/244KhOWGYDi5SthDehxkx3r Kuvmj+BUflnDYXI2cDR/mJGaDHFik6DmzAvTsdbVgxgUaAQ/2lEWBvwTWGJTmx++ jDvNOhUzDsLzTVqM0wiJS7jEtrsi4s+FuTVF3AUKyTbebgnT/JCG6KCJO6JDYEyL +hJg5ZsfA/d4FQ6n2eZzo+QT7AjHXtWfTXb5kbC3oRRUKAjV0ymZjiumecLLZyGf tNS+9s4JlHzPRNlyE/Jvz1eEve88uQPaqWQWuIMqrpXZKS7owMfcecfoKlylqYCY jg0bvkV1xK8CT5LCIuXHqTpWHd+IU8qzYcMW+zdjzvxnkwOASxGZKX3WQ//uYJQ8 dTdvsHmGXlCQ1OxkxCjHEZh6oR2yIciJpa69ogK9xd5uh4ZJGULgUn21qzNd/xH3 VdlGuJ8tqGXcKSwIEGNRrKDxbNXvzbv63pp0G+va75GM0Wuj0CjgIeZ0Hrlxq9Ao KA4hFYkypKczobe29nkSzFwh/Wd7rHaUmNvpu8WiEc9ZPIX7f2E6AJHitkQ6C2lL rZ9HDSCuIHL0dC+YMj/RE00meTl+fWsooHh8O5oFF/OF1GkIPDQW0qp4ctK/YUPP iC7KT7JNVeebwgX5CT8f3SnGmA90wNtpqUNaMULeZrxdD6SZU/en42GL/JT7l2Az +VIsbX1z92QC573cpU2D =zRmt -----END PGP SIGNATURE----- --uaeuxgrhrIB2nxxjinPocCordRdhJBBak--