Date: Sat, 22 Apr 2023 12:01:53 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 270989] print/ghostscript10: adds libgs.so; connects to USES and DEFAULT_VERSIONS facilities; flavorized Message-ID: <bug-270989-7788-VjCInZJk1Q@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-270989-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-270989-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270989 --- Comment #2 from Daniel Engberg <diizzy@FreeBSD.org> --- Thanks for the patch, looks good overall but I have a few inputs having a q= uick look at it. Changes to Mk/Uses/ghostscript.mk should go into a separate patch PORTVERSION --> DISTVERSION For overall consistency in tree I'd suggest that we make a nox11 variant ra= ther than x11 and remove base from naming Use ".if ${FLAVOR} =3D=3D nox11" instead of .if !empty(FLAVOR:Mx11) L104 and L105 is a way to do it but I think for the sake of readability its better to wrap it around .if statements --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-270989-7788-VjCInZJk1Q>