Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Apr 2023 20:16:21 +0000
From:      Antoine Brodin <antoine@freebsd.org>
To:        Muhammad Moinur Rahman <bofh@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,  dev-commits-ports-main@freebsd.org
Subject:   Re: git: 9f5034f55a47 - main - Mk/Uses/php.mk: Refactor
Message-ID:  <CAALwa8k6J%2Bc3KWuc1o_h9ZLCUf9xiZRpU4EMMM0MyVhzKfUO%2Bw@mail.gmail.com>
In-Reply-To: <202304242001.33OK19wU009301@gitrepo.freebsd.org>
References:  <202304242001.33OK19wU009301@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 24, 2023 at 8:01=E2=80=AFPM Muhammad Moinur Rahman <bofh@freebs=
d.org> wrote:
>
> The branch main has been updated by bofh:
>
> URL: https://cgit.FreeBSD.org/ports/commit/?id=3D9f5034f55a47591288167cd4=
9fe4bb963143caed
>
> commit 9f5034f55a47591288167cd49fe4bb963143caed
> Author:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
> AuthorDate: 2023-04-24 19:59:31 +0000
> Commit:     Muhammad Moinur Rahman <bofh@FreeBSD.org>
> CommitDate: 2023-04-24 20:01:01 +0000
>
>     Mk/Uses/php.mk: Refactor
>
>     - Replace old USE_APACHE_RUN with USES=3Dapache:run
>     - Prior to php8.0 there was a check for the required libname which
>       contained the version number of php. Remove the conditional.
>
>     Sponsored by:   Bounce Experts
> ---
>  Mk/Uses/php.mk | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Hi,

Overriding USES doesn't look good.
Maybe it should be something like this instead:
apache_ARGS?=3Drun
.include "${USESDIR}/apache.mk"

Antoine



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8k6J%2Bc3KWuc1o_h9ZLCUf9xiZRpU4EMMM0MyVhzKfUO%2Bw>