Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Jun 2023 16:12:42 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 271954] [NEW PORT] x11-wm/emwm Enhanced Motif Window Manager
Message-ID:  <bug-271954-7788-Ybhzkivs8a@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-271954-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-271954-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271954

Stephan Lichtenauer <stephan@lichtenauer.co.za> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242737|0                           |1
        is obsolete|                            |
 Attachment #243082|                            |maintainer-approval+
              Flags|                            |

--- Comment #3 from Stephan Lichtenauer <stephan@lichtenauer.co.za> ---
Created attachment 243082
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D243082&action=
=3Dedit
Updated patch including fixes for all comments.

Thank you very much for your feedback, please find updated patch attached.

> instead of EXTRACT_SUFFIX, add USES=3Dtar:xz
Done.

> please hard-break pkg-descr to 72 or 80 columns.
Done.

> please add a blank line before the LICENSE block.  You can use portfmt
  to auto-format the port.
Reformatted with portfmt.

> do not hard code /usr/bin/install.  Instead, use the INSTALL_... macros
  described in =C2=A7 5.17.1 Porter's Handbook.
Changed and also fixed pkg-plist to include the directories.

> please set the author field in your patch to your true email address and
  name.  Also check if you can set name and surname in bugzilla to make it
  easier for us to enter correct metadata into version control.
Done.

> make sure to hook the new port into x11-wm/Makefile.
Done.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-271954-7788-Ybhzkivs8a>