From owner-svn-ports-all@freebsd.org Tue Mar 20 09:46:38 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8231EF62B8B; Tue, 20 Mar 2018 09:46:38 +0000 (UTC) (envelope-from luca.pizzamiglio@gmail.com) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com [209.85.223.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1FA3069D08; Tue, 20 Mar 2018 09:46:37 +0000 (UTC) (envelope-from luca.pizzamiglio@gmail.com) Received: by mail-io0-f178.google.com with SMTP id e7so1549217iof.2; Tue, 20 Mar 2018 02:46:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QnzkF07PBxTUY03FmdIWwBvFXIkxh3AS2NSlaAkvfms=; b=ChOwbFw1aovIPuXeBhU15tW5eBxsYqmu5dwtkokLlf2n12fDTltDwaLe0ftSWpt0fO u0CkoTI1EqtPRztiFJiJcdqgfcmIxKSp0FbJQGwqhuv7HBWcVG22sIItyYObzs3H7d+n bNY9Dg8yyNHijqg2q0/LBxzESNZRse+CgHYpH6jV95Ob+tiZPdTccqi5uUaOo2kt0Msw tVLqIQ18ShinktcBonNzyqBxRY2pgQ/hl7pq0i7lL43SYdjOEp82yM7GgkKeAY/zmCSN TcnKdGox/twI3cNL7GWLweh6dGnt5C35AFcB6pKWl2kuPIiNNsLDRUQv+4AXmaemMnfq nVpA== X-Gm-Message-State: AElRT7HcCMul2FF5MQqMAB5QknA1L3OkVCbH6ig2uFp4O6V52pVpv3OV Ix6cipGRCcnG+9XHDqGemayIcrqa X-Google-Smtp-Source: AG47ELvkaOFtAaeuzbWa2PAJD51uzgGG1YwNPOklNff64XwY9CFH+fLh9JnwwLKqsTgN8BCmFNo6ow== X-Received: by 10.107.2.7 with SMTP id 7mr15550831ioc.187.1521539191435; Tue, 20 Mar 2018 02:46:31 -0700 (PDT) Received: from mail-io0-f169.google.com (mail-io0-f169.google.com. [209.85.223.169]) by smtp.gmail.com with ESMTPSA id v198-v6sm959972ita.29.2018.03.20.02.46.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Mar 2018 02:46:30 -0700 (PDT) Received: by mail-io0-f169.google.com with SMTP id g14so1533052iob.13; Tue, 20 Mar 2018 02:46:30 -0700 (PDT) X-Received: by 10.107.80.15 with SMTP id e15mr2455247iob.40.1521539190695; Tue, 20 Mar 2018 02:46:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.27.4 with HTTP; Tue, 20 Mar 2018 02:46:09 -0700 (PDT) In-Reply-To: <20180319223315.ysxwrw6grvarmbr6@atuin.in.mat.cc> References: <201803151455.w2FEtQkI026557@repo.freebsd.org> <20180319223315.ysxwrw6grvarmbr6@atuin.in.mat.cc> From: Luca Pizzamiglio Date: Tue, 20 Mar 2018 10:46:09 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r464591 - in head/devel: . pecl-xdebug26 pecl-xdebug26/files To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 09:46:38 -0000 The current default version of PHP is 5.6, that's why I decided to keep 2.5 as the default version and xdebug26 as kinda -devel. and I started this work before PHP flavour were introduced. But you have a valid point, there's no specific reason to have 2.5 and 2.6 with PHP 7.0 and 7.1. I'll rework it soon. Thanks! Best regards, Luca On Mon, Mar 19, 2018 at 11:33 PM, Mathieu Arnold wrote: > On Thu, Mar 15, 2018 at 02:55:26PM +0000, Luca Pizzamiglio wrote: > > SUBDIR += pecl-xdebug > > + SUBDIR += pecl-xdebug26 > > +DISTVERSION= 2.6.0 > > +IGNORE_WITH_PHP= 56 > > Unless there is a specific reason to have both xdebug 2.5 and 2.6 for > PHP 7.0 and 7.2, you should probably have updated the main port to 2.6 > and repocopied it to a xdebug25 with without any PKGNAMESUFFIX, and > limited to PHP 5.6. only. > > -- > Mathieu Arnold >