From owner-cvs-all@FreeBSD.ORG Wed Sep 27 21:03:39 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E8C6416A415; Wed, 27 Sep 2006 21:03:39 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5487643D45; Wed, 27 Sep 2006 21:03:39 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k8RL3bw1061032; Wed, 27 Sep 2006 17:03:37 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Wed, 27 Sep 2006 13:38:21 -0400 User-Agent: KMail/1.9.1 References: <200609261608.k8QG8TYB044266@repoman.freebsd.org> <200609271117.25831.jhb@freebsd.org> <451A9E1E.30601@samsco.org> In-Reply-To: <451A9E1E.30601@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200609271338.22284.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Wed, 27 Sep 2006 17:03:37 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/1948/Wed Sep 27 12:03:03 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.1 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00, DATE_IN_PAST_03_06 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Maxim Sobolev , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/i386/i386 local_apic.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2006 21:03:40 -0000 On Wednesday 27 September 2006 11:51, Scott Long wrote: > John Baldwin wrote: > > On Tuesday 26 September 2006 19:08, Maxim Sobolev wrote: > > > >>John Baldwin wrote: > >> > >>>On Tuesday 26 September 2006 12:08, Maxim Sobolev wrote: > >>> > >>>>sobomax 2006-09-26 16:08:29 UTC > >>>> > >>>> FreeBSD src repository > >>>> > >>>> Modified files: (Branch: RELENG_6) > >>>> sys/i386/i386 local_apic.c > >>>> Log: > >>>> Revert 1.17.2.8, which reportedly causes problems on some hardware. > >>> > >>>The report I saw was that it broke ULE in general. Are you going to > > > > revert it > > > >>>from amd64 as well? > >> > >>Yes, you are right - this is ULE specific bug. In fact, quick grep of > >>the ULE code reveals that it doesn't honor hlt_cpus_mask, so that the > >>problem is with ULE, not with the change in question. > > > > > > Well, hlt_cpus_mask is really an x86-specific hack. :) > > > > x86 and amd64, which represent about 95% of FreeBSD. My point is that we need a notion of taking CPUs offline and online with scheudler hooks, instead of exporting a simple x86-specific bitmask. Right now we don't notify the schedulers when a CPU goes offline so that they can try to do sensible things with pinned and bound threads, etc. Instead, they just have to "notice" which is rediculously lame. -- John Baldwin