From owner-svn-src-all@freebsd.org Tue Apr 17 15:30:56 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DEF4BF83F1D for ; Tue, 17 Apr 2018 15:30:55 +0000 (UTC) (envelope-from ram.vegesna@broadcom.com) Received: from mail-lf0-x232.google.com (mail-lf0-x232.google.com [IPv6:2a00:1450:4010:c07::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 488356854D for ; Tue, 17 Apr 2018 15:30:55 +0000 (UTC) (envelope-from ram.vegesna@broadcom.com) Received: by mail-lf0-x232.google.com with SMTP id b23-v6so9026467lfg.4 for ; Tue, 17 Apr 2018 08:30:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=qqy5m6I7x4BzoeoU3YEaXxk3tPlhW+o/SOhUDn+SOko=; b=LRtaEXm4Y06Y9hbecQA8VF5R5RNry+Y9OWPJ0mrcBpA/JJUpRagnO0em+CD1iclecu 08Vw+BepnlhiECDOlr1X+I8ZHeES29qrcEeA9p4y+dgTIpFx1R58MmP0xKGY+gir/lB7 qiDhXRC4fJ7l5zfb7q/EwT7JGqUhQq9L54xYNNJuNm3lNQjM4fw3MmF3DRiqxyZAAUu3 KYufgtgbsPI+hBYT33/vLLtC9N9O5AkS36t+rUA+zPbJPZnlQ4eEgHFYllqLhxwxTqYP tFXQwfeX8KOrgZF6kIOX66Xm/vqU1SUPUEJiJAN/tZVx20o1xGHvrYsVdPqrP07D7t66 W+AQ== X-Gm-Message-State: ALQs6tAlD39L4E+tk5668Cvq6TtFCztcuD9eSpEKs+Q38vSBU/Sb+0U3 +pwUNCIQRGe6D/Z8dUgVRQ8GcsckTrMxW1MJ+gOg8qf9 X-Google-Smtp-Source: AIpwx4/0iwow87UUeBMSEEvT/8ywSBHINslb2PX+iTfBE39uNGGBPfi4/80Oi1SV4geXfzeWyJ8b3feqxbVlrT8ZMBw= X-Received: by 2002:a19:9b08:: with SMTP id d8-v6mr2053218lfe.66.1523979053708; Tue, 17 Apr 2018 08:30:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.134.205 with HTTP; Tue, 17 Apr 2018 08:30:53 -0700 (PDT) In-Reply-To: References: <201804131331.w3DDVKod044086@repo.freebsd.org> From: Ram Kishore Vegesna Date: Tue, 17 Apr 2018 21:00:53 +0530 Message-ID: Subject: Re: svn commit: r332471 - head/sys/dev/ocs_fc To: Oliver Pinter Cc: Ram Kishore Vegesna , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Bruce Evans Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 15:30:56 -0000 Thanks Oliver, For pointing the issue. Checked in the change. -Ram On Sat, Apr 14, 2018 at 3:32 AM, Oliver Pinter < oliver.pinter@hardenedbsd.org> wrote: > > > On Friday, April 13, 2018, Ram Kishore Vegesna wrote: > >> Author: ram >> Date: Fri Apr 13 13:31:20 2018 >> New Revision: 332471 >> URL: https://svnweb.freebsd.org/changeset/base/332471 >> >> Log: >> Check if STACK is defined before using the stack(9). >> >> PR: 227446 >> Reported by: emaste >> Approved by: ken >> >> Modified: >> head/sys/dev/ocs_fc/ocs_os.c >> >> Modified: head/sys/dev/ocs_fc/ocs_os.c >> ============================================================ >> ================== >> --- head/sys/dev/ocs_fc/ocs_os.c Fri Apr 13 13:23:31 2018 >> (r332470) >> +++ head/sys/dev/ocs_fc/ocs_os.c Fri Apr 13 13:31:20 2018 >> (r332471) >> @@ -37,6 +37,7 @@ >> */ >> >> #include "ocs.h" >> +#include "opt_stack.h" > > > These types of includes - where you includes opts - should go before any > other includes. > > > >> #include >> #include >> #include /* for debug of memory >> allocations */ >> @@ -855,11 +856,13 @@ void ocs_intr_enable(ocs_os_handle_t os) >> >> void ocs_print_stack(void) >> { >> +#if defined(STACK) >> struct stack st; >> >> stack_zero(&st); >> stack_save(&st); >> stack_print(&st); >> +#endif >> } >> >> void ocs_abort(void) >> _______________________________________________ >> svn-src-head@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >> >