Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 4 Jun 2020 22:39:10 +0200
From:      =?UTF-8?Q?Stefan_E=c3=9fer?= <se@freebsd.org>
To:        Kyle Evans <kevans@freebsd.org>, Kirk McKusick <mckusick@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r361801 - head/sys/ufs/ffs
Message-ID:  <a2df182f-6eb7-0d4a-0989-38a9ae08df3b@freebsd.org>
In-Reply-To: <CACNAnaHLgL1MMnV%2BEjW37Yqj5KBmmkVTyveCsvOpgT3ZbJmx1w@mail.gmail.com>
References:  <202006041835.054IZLMs097931@repo.freebsd.org> <CACNAnaHLgL1MMnV%2BEjW37Yqj5KBmmkVTyveCsvOpgT3ZbJmx1w@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Am 04.06.20 um 21:48 schrieb Kyle Evans:
> On Thu, Jun 4, 2020 at 1:35 PM Kirk McKusick <mckusick@freebsd.org> wrote:
[...]
>> Modified: head/sys/ufs/ffs/ffs_balloc.c
>> ==============================================================================
>> --- head/sys/ufs/ffs/ffs_balloc.c       Thu Jun  4 18:19:16 2020        (r361800)
>> +++ head/sys/ufs/ffs/ffs_balloc.c       Thu Jun  4 18:35:21 2020        (r361801)
>> @@ -154,7 +154,8 @@ ffs_balloc_ufs1(struct vnode *vp, off_t startoffset, i
>>                         ip->i_size = smalllblktosize(fs, nb + 1);
>>                         dp->di_size = ip->i_size;
>>                         dp->di_db[nb] = dbtofsb(fs, bp->b_blkno);
>> -                       UFS_INODE_SET_FLAG(ip, IN_CHANGE | IN_UPDATE);
>> +                       UFS_INODE_SET_FLAG(ip,
>> +                           IN_CHANGE | IN_UPDATE | IN_IBLKDATA);
>>                         if (flags & IO_SYNC)
>>                                 bwrite(bp);
>>                         else if (DOINGASYNC(vp))
>> @@ -647,7 +648,7 @@ ffs_balloc_ufs2(struct vnode *vp, off_t startoffset, i
>>                                 dp->di_extsize = smalllblktosize(fs, nb + 1);
>>                                 dp->di_extb[nb] = dbtofsb(fs, bp->b_blkno);
>>                                 bp->b_xflags |= BX_ALTDATA;
>> -                               UFS_INODE_SET_FLAG(ip, IN_CHANGE);
>> +                               UFS_INODE_SET_FLAG(ip, IN_CHANGE | IN_BLKDATA);
>>                                 if (flags & IO_SYNC)
>>                                         bwrite(bp);
>>                                 else
> 
> Hello!
> 
> This second one seems to have been accidentally misspelled as "IN_BLKDATA"

I had noticed this independently since my kernel builds failed and took
liberty to commit a fix of this obvious typo.

Regards, STefan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a2df182f-6eb7-0d4a-0989-38a9ae08df3b>