From owner-svn-src-head@freebsd.org Thu Dec 7 21:24:01 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D61CE91B34 for ; Thu, 7 Dec 2017 21:24:01 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-wm0-x22d.google.com (mail-wm0-x22d.google.com [IPv6:2a00:1450:400c:c09::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A5E9C770E5 for ; Thu, 7 Dec 2017 21:24:00 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-wm0-x22d.google.com with SMTP id g130so2242248wme.0 for ; Thu, 07 Dec 2017 13:24:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UVUR3Rj7ohP0vzUjUnFcLTv4wAjt+3B1QEGmIX/ZYR8=; b=B4lN1bNuty+BQ99AHlfLiPIE03ObLvYWUblK8s09i4RbgwtcSUgKJl0/G2NyEu0FrY GX8TKXRHeND6MQ6vaAql5cfi0+5jUu45k/8olqrSlOvi91JBFKK48zZo1I3I8FIE+Oji TNsNAzKq48KyQbMMChMS4lZUy6Gqn9ftDJzJwV9GuiG0mBIgJb2uMKIjMap+5vZarpcW eZNkDzM1uMEa0kQbdboCc2cir3UgWYL1RHUgEH3OH5l3K+dAQoUX7nkuiimKrnzlrLU5 Xa0Ha0m+ZhllIPNjzQSYdWyAj4kWXVYQF0YNFl/E61jAuXdQDBQpmRuXNl8v3LYXWn3Y JDrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UVUR3Rj7ohP0vzUjUnFcLTv4wAjt+3B1QEGmIX/ZYR8=; b=QQX5Q9FbYJjlWtDq/ju98eEWpp97xlwoV6KrjpKApBBrH9Tb9iYui8uWXHqFVDvtib xexrWQbHH+vXrq9Xgjn7gPo0n/UHZtuj/hUE5useT9QeQCm1laUyosLUOH6OZwHFVa5i VxOe7L5RF/VL4nujAK3PTpn7tNNCLXKEargMsvUpgOd9eo29rRgcrxIp9OlFRMfAwXV3 LdX/4QJ9U58xS6z6fr/ktmpTRV0OqOdIX5plnAoekU2FycnnCTuPHNmdzOsR4oACg0Lq bTc1lAmHoN/AV00IjE9/DB26gV/sw2MG6x5Ozu68B7D7Cjfw6/8rya81jNhiCrd36ubl cOlA== X-Gm-Message-State: AJaThX44j/MsW+ampnFVMHQy/A059gDMt8+y5ZrLmokEHWZ0Vwspv6gM U8lW/ikU8oRMPZ3qa0cRpDWOVouEvjfWOwI8HpZZSg== X-Google-Smtp-Source: AGs4zMbsKdWckZCSCLCcPFrpojfV+gP285eBtFQFojAdosUQepT9BzL6JGHXxjxQw1993Z7bI/smcCnxO+lYprImomg= X-Received: by 10.80.140.176 with SMTP id q45mr49376574edq.186.1512681839025; Thu, 07 Dec 2017 13:23:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.149.174 with HTTP; Thu, 7 Dec 2017 13:23:58 -0800 (PST) In-Reply-To: <201712071938.vB7Jc9Ck083315@repo.freebsd.org> References: <201712071938.vB7Jc9Ck083315@repo.freebsd.org> From: Oliver Pinter Date: Thu, 7 Dec 2017 22:23:58 +0100 Message-ID: Subject: Re: svn commit: r326664 - head/sys/vm To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 21:24:01 -0000 On 12/7/17, Mark Johnston wrote: > Author: markj > Date: Thu Dec 7 19:38:09 2017 > New Revision: 326664 > URL: https://svnweb.freebsd.org/changeset/base/326664 > > Log: > Fix the UMA reclaim worker after r326347. > > atomic_set_*() sets a bit in the target memory location, so > atomic_set_int(&uma_reclaim_needed, 0) does not do what it looks like > it does. > > PR: 224080 > Reviewed by: jeff, kib > Differential Revision: https://reviews.freebsd.org/D13412 > > Modified: > head/sys/vm/uma_core.c > > Modified: head/sys/vm/uma_core.c > ============================================================================== > --- head/sys/vm/uma_core.c Thu Dec 7 18:04:48 2017 (r326663) > +++ head/sys/vm/uma_core.c Thu Dec 7 19:38:09 2017 (r326664) > @@ -3177,7 +3177,7 @@ uma_reclaim_worker(void *arg __unused) > EVENTHANDLER_INVOKE(vm_lowmem, VM_LOW_KMEM); > sx_xlock(&uma_drain_lock); > uma_reclaim_locked(true); > - atomic_set_int(&uma_reclaim_needed, 0); > + uma_reclaim_needed = 0; atomic_store_rel_int(&uma_reclaim_needed, 0) ? > sx_xunlock(&uma_drain_lock); > /* Don't fire more than once per-second. */ > pause("umarclslp", hz); > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >