From owner-freebsd-net@FreeBSD.ORG  Thu May 17 08:14:58 2007
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@freebsd.org
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 836CB16A400
	for <freebsd-net@freebsd.org>; Thu, 17 May 2007 08:14:58 +0000 (UTC)
	(envelope-from danny@cs.huji.ac.il)
Received: from cs1.cs.huji.ac.il (cs1.cs.huji.ac.il [132.65.16.10])
	by mx1.freebsd.org (Postfix) with ESMTP id 3B97A13C44B
	for <freebsd-net@freebsd.org>; Thu, 17 May 2007 08:14:57 +0000 (UTC)
	(envelope-from danny@cs.huji.ac.il)
Received: from pampa.cs.huji.ac.il ([132.65.80.32])
	by cs1.cs.huji.ac.il with esmtp
	id 1Hoaqf-000KtG-QQ; Thu, 17 May 2007 10:56:33 +0300
X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2
To: "Jack Vogel" <jfvogel@gmail.com>
In-reply-to: <2a41acea0705161118g241a3375x7367bbc10a7c7d82@mail.gmail.com> 
References: <2a41acea0705161030k40831aa5o168b5bc40fcf3352@mail.gmail.com> 
	<20070516181531.GA62119@voi.aagh.net>
	<2a41acea0705161118g241a3375x7367bbc10a7c7d82@mail.gmail.com>
Comments: In-reply-to "Jack Vogel" <jfvogel@gmail.com>
	message dated "Wed, 16 May 2007 11:18:28 -0700."
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Thu, 17 May 2007 10:56:33 +0300
From: Danny Braniss <danny@cs.huji.ac.il>
Message-ID: <E1Hoaqf-000KtG-QQ@cs1.cs.huji.ac.il>
Cc: freebsd-net <freebsd-net@freebsd.org>,
	FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: EM and TSO 
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 May 2007 08:14:58 -0000

> On 5/16/07, Thomas Hurst <tom.hurst@clara.net> wrote:
> > * Jack Vogel (jfvogel@gmail.com) wrote:
> >
> > >  I introduced a change yesterday that limited TSO to PCI Express
> > >  adapters, I did this more for avoidance rather than a bug fix, and
> > >  I'm not 100% sure its the right thing, so I thought I would poll
> > >  everyone, do you have a PCI-X adapter and are using TSO without
> > >  problems and wish to keep the support in?
> > >
> > >  If no one is then I'll just leave it as is.
> >
> > We put CURRENT on one of our Sun X4200's for some MySQL tests a few days
> > ago and haven't noticed any problems, though it's only handled a few
> > million packets so far.
> >
> > Does this change remove support or just disable it by default?
> 
> It removed it, but Andre and my own guilty conscience has convinced
> me that I should change it back, once I get an MSI/X bug that was
> discovered with the code solved there will be another delta that will
> reenable it for PCI-X again.

em0@pci1:1:0:   class=0x020000 card=0x10118086 chip=0x10108086 rev=0x03 
hdr=0x00
    vendor     = 'Intel Corporation'
    device     = '82546EB Dual Port Gigabit Ethernet Controller (Copper)'
    class      = network
    subclass   = ethernet
    cap 01[dc] = powerspec 2  supports D0 D3  current D0
    cap 07[e4] = PCI-X 64-bit supports 133MHz, 2048 burst read, 1 split 
transaction
    cap 05[f0] = MSI supports 1 message, 64 bit 

I have been testing TSO on a SunFire X4100, and though it works, I notice
that setting it on actually reduces throughput, from an average of 55MB/s
to 24MB/s

any explanation?

danny