From owner-svn-src-user@FreeBSD.ORG Wed Oct 17 23:51:52 2012 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4FD60ED6 for ; Wed, 17 Oct 2012 23:51:52 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by mx1.freebsd.org (Postfix) with ESMTP id 16CEE8FC16 for ; Wed, 17 Oct 2012 23:51:48 +0000 (UTC) Received: by mail-pa0-f54.google.com with SMTP id bi1so8283762pad.13 for ; Wed, 17 Oct 2012 16:51:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=+BxYtDb4BrKiyOxBHt+j6LU7KABjtP7KNwD3UvO+qio=; b=G9hosPlHNydb8de2CRPu9+QsYJamTiIFJDrHYKDeXNLBDT3j0WLu41QAVyVqwyc0hl DYEOcMytUBZVWh+nDlWbj0CYaDLRsrPnKjajQLDvgMKt/Uz0drIS8fJytkS54n02Zqdt NeZwc7h/d/OCrOofN3E2elFKY/KLHs+0GpP3k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=+BxYtDb4BrKiyOxBHt+j6LU7KABjtP7KNwD3UvO+qio=; b=QOcpoELdFgar4lG4CTMnl7/QmjV9D2b8kjtyeh+52rbz6POLdrm6aq4CMBveH8ofIC y1E1qe+P1pqfybX4pGBD83FjzOVXDTs7GdXQHXdtaD4r6rYt518byZYAqevE1viSNytP BoSgvM9FH6NDDYEiVh6DjkR3Irp0LgtihxE4kFCkvJHqmS8pcr7jpS5b+jrXPkVIxZRJ k1ODBDM2TdF3PQZAf4YfXVz6vtWGNIrHrai4/ux29Zl3ne1OnKOEcn7juKf4pg1ddRrj HaM8ZNSkK8kd6gAUyHSrRq7EiaFDy0UCVfVBrDsjbT0tqLAzTj/2vOj7WoQg5H8+S8vd hXtA== Received: by 10.68.242.231 with SMTP id wt7mr60527104pbc.99.1350517908507; Wed, 17 Oct 2012 16:51:48 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.66.161.163 with HTTP; Wed, 17 Oct 2012 16:51:18 -0700 (PDT) In-Reply-To: <201210172017.q9HKHuPT054844@svn.freebsd.org> References: <201210172017.q9HKHuPT054844@svn.freebsd.org> From: Eitan Adler Date: Wed, 17 Oct 2012 19:51:18 -0400 X-Google-Sender-Auth: 35cxcH-goDllZUxAB6x75OzkP3I Message-ID: Subject: Re: svn commit: r241647 - user/crees/rclint To: Chris Rees Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmu4JyoJHlmugBEvPHRm5yV3e3fuE9w41vMFE8Btk7o9X36UkTpql2IX6YMi9g8J2UmXIAR Cc: src-committers@freebsd.org, svn-src-user@freebsd.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2012 23:51:52 -0000 more fun! On 17 October 2012 16:17, Chris Rees wrote: > +#regex explain explanation > +^[^#{}.l\s][^-=()]*[^)]$ Unassociated shell command Do not put shell commands outside functions-- it slows down rc on boot and every invocation of the rc file is this missing a \ before the \? > def get_assignment(line): > try: > - return re.match('(\S+)=(\S+)$', line).groups() > + return re.match('(\S+)=(.+)$', line).groups() ditto -- Eitan Adler Source & Ports committer X11, Bugmeister, Ports Security teams