From owner-svn-ports-all@FreeBSD.ORG Tue Jun 16 09:50:50 2015 Return-Path: Delivered-To: svn-ports-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5AC2F9EA; Tue, 16 Jun 2015 09:50:50 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 343D4D28; Tue, 16 Jun 2015 09:50:49 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [192.168.1.20] (34.Red-83-54-25.dynamicIP.rima-tde.net [83.54.25.34]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 16BF543CA5; Tue, 16 Jun 2015 04:50:40 -0500 (CDT) Message-ID: <557FF16E.20706@marino.st> Date: Tue, 16 Jun 2015 11:50:38 +0200 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r389830 - head/cad/ghdl References: <201506160943.t5G9h14w060858@svn.freebsd.org> In-Reply-To: <201506160943.t5G9h14w060858@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 09:50:50 -0000 On 6/16/2015 11:43, Mathieu Arnold wrote: > Author: mat > Date: Tue Jun 16 09:43:00 2015 > New Revision: 389830 > URL: https://svnweb.freebsd.org/changeset/ports/389830 > > Log: > CLeanup USE_GITHUB usage. > > With hat: portmgr > Sponsored by: Absolight > > Modified: > head/cad/ghdl/Makefile > > Modified: head/cad/ghdl/Makefile > ============================================================================== > --- head/cad/ghdl/Makefile Tue Jun 16 09:36:09 2015 (r389829) > +++ head/cad/ghdl/Makefile Tue Jun 16 09:43:00 2015 (r389830) > @@ -5,7 +5,7 @@ PORTNAME= ghdl > PORTVERSION= 0.32 > PORTREVISION= 2 > CATEGORIES= cad > -DISTFILES= ${SRCDISTFILE} ${GCCDISTFILE} > +DISTFILES= ${DISTNAME}${EXTRACT_SUFX} > > MAINTAINER= marino@FreeBSD.org > COMMENT= GNU VHDL simulator > @@ -26,7 +26,6 @@ GH_TAGNAME= 5adb2f6 > GNU_CONFIGURE= yes > GCCVER= 4.9.2 > LLVMVER= 35 > -SRCDISTFILE= hanzer-${GH_PROJECT}-${PORTVERSION}-${GH_TAGNAME}_GH0.tar.gz > BLD_TARGET= ${ARCH:S/amd64/x86_64/}-portbld-${OPSYS:tl}${OSREL:R} > BUILDDIR= ${WRKDIR}/build > GCCSRCDIR= ${WRKDIR}/gcc-${GCCVER} > @@ -93,7 +92,7 @@ EXTRA_CONFIG+= --with-ld=/usr/bin/ld > EXTRA_CONFIG+= --with-as=${AS_COMMAND} > > .if ${PORT_OPTIONS:MGCC} > -GCCDISTFILE= gcc-${GCCVER}.tar.bz2 > +DISTFILES+= gcc-${GCCVER}.tar.bz2 > USES+= iconv libtool makeinfo perl5 > USE_PERL5= build > INFO= ghdl > It is my understanding that one is not to add DISTFILES, e.g. avoid "DISTFILES+=" due to how Mk/bsd* works. What was wrong with what I had, something I put a LOT of thought into? Also, I hate EXTRACT_SUFX. This wasn't broken, so I think this change was pushing it a bit. I would not have approved it if presented. John