From owner-svn-src-all@FreeBSD.ORG Sat Oct 24 18:49:18 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 84A7A1065693; Sat, 24 Oct 2009 18:49:18 +0000 (UTC) (envelope-from ru@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 73ED58FC29; Sat, 24 Oct 2009 18:49:18 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n9OInIxZ005412; Sat, 24 Oct 2009 18:49:18 GMT (envelope-from ru@svn.freebsd.org) Received: (from ru@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n9OInIvI005409; Sat, 24 Oct 2009 18:49:18 GMT (envelope-from ru@svn.freebsd.org) Message-Id: <200910241849.n9OInIvI005409@svn.freebsd.org> From: Ruslan Ermilov Date: Sat, 24 Oct 2009 18:49:18 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r198448 - in head/sys: fs/smbfs netgraph X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2009 18:49:18 -0000 Author: ru Date: Sat Oct 24 18:49:17 2009 New Revision: 198448 URL: http://svn.freebsd.org/changeset/base/198448 Log: Spell DIAGNOSTIC correctly. Modified: head/sys/fs/smbfs/smbfs_vfsops.c head/sys/netgraph/NOTES Modified: head/sys/fs/smbfs/smbfs_vfsops.c ============================================================================== --- head/sys/fs/smbfs/smbfs_vfsops.c Sat Oct 24 18:38:24 2009 (r198447) +++ head/sys/fs/smbfs/smbfs_vfsops.c Sat Oct 24 18:49:17 2009 (r198448) @@ -259,7 +259,7 @@ smbfs_mount(struct mount *mp) VOP_UNLOCK(vp, 0); SMBVDEBUG("root.v_usecount = %d\n", vrefcnt(vp)); -#ifdef DIAGNOSTICS +#ifdef DIAGNOSTIC SMBERROR("mp=%p\n", mp); #endif return error; Modified: head/sys/netgraph/NOTES ============================================================================== --- head/sys/netgraph/NOTES Sat Oct 24 18:38:24 2009 (r198447) +++ head/sys/netgraph/NOTES Sat Oct 24 18:49:17 2009 (r198448) @@ -76,10 +76,10 @@ Archie's suggestions... :-) be careful with things like #ifdef INET. - All nodes assume that all data mbufs have the M_PKTHDR flag set! The ng_send_data() and related functions should have an - #ifdef DIAGNOSTICS check to check this assumption for every mbuf. + #ifdef DIAGNOSTIC check to check this assumption for every mbuf. -DONE with INVARIANTS. Framework should test this more. - More generally, netgraph code should make liberal use of the - #ifdef DIAGNOSTICS definition. + #ifdef DIAGNOSTIC definition. -INVARIANTS. - Since data and messages are sent functionally, programmers need to watch out for infinite feedback loops. Should ng_base.c detect