From owner-freebsd-hackers  Mon Aug 19 16:24:08 1996
Return-Path: owner-hackers
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id QAA26827
          for hackers-outgoing; Mon, 19 Aug 1996 16:24:08 -0700 (PDT)
Received: from red.jnx.com (ppp-206-170-2-24.sntc01.pacbell.net [206.170.2.24])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id QAA26821;
          Mon, 19 Aug 1996 16:24:04 -0700 (PDT)
Received: from base.jnx.com (base.jnx.com [208.197.169.238]) by red.jnx.com (8.7.5/8.7.3) with ESMTP id QAA23275; Mon, 19 Aug 1996 16:23:59 -0700 (PDT)
Received: from base.jnx.com (localhost.jnx.com [127.0.0.1]) by base.jnx.com (8.7.5/8.7.3) with ESMTP id QAA21732; Mon, 19 Aug 1996 16:23:50 -0700 (PDT)
Message-Id: <199608192323.QAA21732@base.jnx.com>
To: Toshihiro Kanda <candy@fct.kgc.co.jp>
cc: wollman@freebsd.org, freebsd-hackers@freebsd.org, olah@freebsd.org
Subject: Re: bin/649 - fix questions (tcpdump / print-atalk.c) 
In-reply-to: Your message of "Sat, 17 Aug 1996 08:53:58 +0900."
             <199608162353.IAA11402@xxx.fct.kgc.co.jp> 
Date: Mon, 19 Aug 1996 16:23:50 -0700
From: Paul Traina <pst@jnx.com>
Sender: owner-hackers@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

The new tcpdump is in place in -current.  Feel free to check it out and
beat it up.

Paul

  From: Toshihiro Kanda <candy@fct.kgc.co.jp>
  Subject: Re: bin/649 - fix questions (tcpdump / print-atalk.c)
  From: Paul Traina <pst@jnx.com>
  Date: Fri, 16 Aug 1996 15:43:06 -0700
  
  > Back in September, you made a change to tcpdump's print-atalk.c code to
  > fix PR # 649.  One of the changes was to print appletalk addresses in hex.
  > This is not, to the best of my knowledge, correct.  Every network monitor o
>>r
  > router that I've seen (cisco, gatorbox, et al) use decimal for the network
  > number and node address.
  > 
  > I'd like to back this change out as part of the upgrade to the current tcpd
>>ump
  > so that we return to canonical address displays.
  > 
  > Objections?
  
    No problem.  There are always confusion printing network number in
  decimal, i.e. 0xfffe is printed as 255.254 or 65534.  I just disliked
  this.
  
    By the way, print-atalk.c is still buggy in handling aarp packet.
  I'd like to send a patch to fix it.  I diff(1)'ed print-atalk.c of
  2.1.5R and mine.  Please check and merge below.
  
    Thank you.
  
  candy@fct.kgc.co.jp (Toshihiro Kanda)
  
  ------8<------------8<------------8<------------8<------------8<------
  *** print-atalk.orig.c	Sat Aug 17 08:47:16 1996
  --- print-atalk.c	Sat Jan 27 15:30:47 1996
  ***************
  *** 167,175 ****
    
    	printf("aarp ");
    	ap = (const struct aarp *)bp;
  ! 	if (ap->htype == 1 && ap->ptype == ETHERTYPE_ATALK &&
    	    ap->halen == 6 && ap->palen == 4 )
  ! 		switch (ap->op) {
    
    		case 1:				/* request */
    			(void)printf("who-has %s tell %s",
  --- 167,175 ----
    
    	printf("aarp ");
    	ap = (const struct aarp *)bp;
  ! 	if (ntohs(ap->htype) == 1 && ntohs(ap->ptype) == ETHERTYPE_ATALK &&
    	    ap->halen == 6 && ap->palen == 4 )
  ! 		switch (ntohs(ap->op)) {
    
    		case 1:				/* request */
    			(void)printf("who-has %s tell %s",
  ***************
  *** 178,184 ****
    
    		case 2:				/* response */
    			(void)printf("reply %s is-at %s",
  ! 			    AT(pdaddr), etheraddr_string(ap->hdaddr));
    			return;
    
    		case 3:				/* probe (oy!) */
  --- 178,184 ----
    
    		case 2:				/* response */
    			(void)printf("reply %s is-at %s",
  ! 			    AT(psaddr), etheraddr_string(ap->hsaddr));
    			return;
    
    		case 3:				/* probe (oy!) */
  ------8<------------8<------------8<------------8<------------8<------