From nobody Tue Sep 30 20:10:55 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cbq2438drz69Cr2; Tue, 30 Sep 2025 20:11:08 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from vogon.madpilot.net (vogon.madpilot.net [IPv6:2a01:4f8:1c1c:11e5::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4cbq2317VGz3kbD; Tue, 30 Sep 2025 20:11:07 +0000 (UTC) (envelope-from mad@madpilot.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=madpilot.net header.s=cyq4qetkgngm header.b="T xtnAhP"; dmarc=pass (policy=quarantine) header.from=madpilot.net; spf=pass (mx1.freebsd.org: domain of mad@madpilot.net designates 2a01:4f8:1c1c:11e5::1 as permitted sender) smtp.mailfrom=mad@madpilot.net Received: from localhost (mail [IPv6:fd5c:5351:d272::3]) by vogon.madpilot.net (Postfix) with ESMTP id 4cbq1t3rFbzLmvv; Tue, 30 Sep 2025 22:10:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=madpilot.net; h= content-transfer-encoding:content-type:content-type:in-reply-to :content-language:references:from:from:subject:subject:date:date :message-id:received; s=cyq4qetkgngm; t=1759263056; x= 1761077457; bh=tnSrBtNMI3z2P6vNzmPN8CHp51M5l+1vBh6bzLcKaVI=; b=T xtnAhPjKbn9tBnrlKL7/kg1ewdUs8Ql0/tWwK/z5XLFwCEHqY/6oSrQrlWMxMtDs ODLuZrUg9SymXv9YTE9LBQqOSNsiPuXgS8HMPxMrQSTdbrtT8skT51T1z9V4Extm q5STT4AXLooJHqAgwqtEzfTt+eX4zcRfO5hbNXBSYpXaYN90UGf7mh+C/ZrPZDfd 2Y3+ao4H18RHUrttZuEDKD54OtD3ZuDCceL1Ia80oVt+ftRGFAJnIWktXyTA4Bnx JcZgaQ6f28qsr0IIQRh/oOU/UygjBketxRuQprw3jEMG3luJsmv/a99QX5wBM6Si MjsR8OoADZ0nKRzRv60oA== Received: from vogon.madpilot.net ([IPv6:fd5c:5351:d272::3]) by localhost (vogon.madpilot.net [IPv6:fd5c:5351:d272::3]) (amavis, port 10026) with ESMTP id S-ufNn9BehFt; Tue, 30 Sep 2025 22:10:56 +0200 (CEST) Message-ID: <9bb0f51a-cb7f-45c4-9a48-bffbadf99845@madpilot.net> Date: Tue, 30 Sep 2025 22:10:55 +0200 Subject: Re: git: 2ffaca551eaf - main - snd_hda: Implement automatic redirection between associations From: Guido Falsi To: Christos Margiolis , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202509301052.58UAqxgM026265@gitrepo.freebsd.org> Content-Language: en-US Autocrypt: addr=mad@madpilot.net; keydata= xsBNBE+G+l0BCADi/WBQ0aRJfnE7LBPsM0G3m/m3Yx7OPu4iYFvS84xawmRHtCNjWIntsxuX fptkmEo3Rsw816WUrek8dxoUAYdHd+EcpBcnnDzfDH5LW/TZ4gbrFezrHPdRp7wdxi23GN80 qPwHEwXuF0X4Wy5V0OO8B6VT/nA0ADYnBDhXS52HGIJ/GCUjgqJn+phDTdCFLvrSFdmgx4Wl c0W5Z1p5cmDF9l8L/hc959AeyNf7I9dXnjekGM9gVv7UDUYzCifR3U8T0fnfdMmS8NeI9NC+ wuREpRO4lKOkTnj9TtQJRiptlhcHQiAlG1cFqs7EQo57Tqq6cxD1FycZJLuC32bGbgalABEB AAHNHkd1aWRvIEZhbHNpIDxtYWRAbWFkcGlsb3QubmV0PsLAeQQTAQgAIwIbAwIeAQIXgAUL CQgHAwUVCgkICwQWAgMBBQJS79AgAhkBAAoJEBrmhg5Wy9KTc0kH/RO64ORBlTbTHaUaOj8F Je5O5NU2Pt9Cyt5ZWBRvxntr1zPTJGKRPS9ihlIfqT4ZvEngQGp57EUyFbCpI0UWasTerImM tt5WACnGmCzUTB39UXx8Oy4b1EgWeTJQ747e/F1mQLXTNa6ijRBE9fYlTb4gAkPN88/wVV9v 3PZozKLTg16ghBzHM/P7Lk8L7clPEZChX1FTa/6eSt3nvzfCuTMZbBPJF/ph+q1KyPqRgVfh tyhu5dvgMoPz/ni41IfeSrkJTD5RXzdyGR9q4Z1NYeBsLkRjC4LxKAP5KqUsvlOUjKvO1byj ApYdMarol+IGkaSk9e3zVYAJkWKjn/ni8XbOwU0EUxB7QQEQAKFhrDceoPdK/IHDSmoj6SQY isvM7VdhcleS7E9DoEAVt7yMbf6HbbMVTTY6ckvwTWQssywLBXNVqxgc4WLJjzfUhgef+WE7 5M3+WFYlOVQLGZY/zEVgma1raYnOHNAOzeHLDmEXjbZP6vGAeDyBbGfQPpE7qGYZ7ubeT3Xw QO+PklcCrvOPj2ZPcAxGNS2xVU/LzONqCrJqLMJSIcCdsbiSP4G5PnDFHtMokaTY6OEr8OEQ fOAerhcHUa/z7Uu8YtmaqKH+QGkE/WEgaRqSiTnv0JOTD+DxehaqvoKPPZ++2NpCZMHB2i6A /xifmQwEiIjEXtcueBRzkNUQkxhqZyS13SrhocL9ydtaVPBzZatAEjUDDEJmAMLVFs45qfyh MiNapHJo2n3MW/E5omqCvEkDdWX/en3P7CK2TemeaDghMsgkNKax/z0wNo5UZCkOPOz0xpNi UilOVbkuezZZNg65741qee2lfXhQIaZ66yT7hphc/N/z3PIAtLeze4u1VR2EXAuZ2sWAdlKC NTlJMsaU/x70BV11Wd/ypnVzM68dfdQIIAj1iMFAD/lXGlEUmKXg5Ov2VQDlTntQoanCYrAg +8CttPzjrydgLZFq3hrtQmfc0se5yv1WHS69+BsUOG09RvvawUDZxUjW19kyeN9THaNRgow3 kSuArUp6zSmJABEBAAHCwF8EGAEIAAkFAlMQe0ECGwwACgkQGuaGDlbL0pMN5wgA4bCkX/qw EVC06ToeR6C2putmSWQMgpDaqrv65Hubo+QGmg2P4ewTYQQ4g6oYWS03qHxqVVWhKz7FjfrV +dH8qbCLfSgIcvdBha7ayGZVrsiuMLKGbw36fcmkZPpSDOfHcP0XH8Z+u9CWj0xUkTxAlZ/7 i6gYSUpG2JWNtdmE/X8VVEyXusCLwy0K0BI60A/4dRTIX3C4QKrJ3ZbUXegz70ynjHf+lQMZ 9IZKASoRMuS5FozPQh6abvmwZEPdf5I9riUElzvHrqJ8Bx0t3Pujdoth+yNHpnBxrtO8LkQd rQ58P0SwcaIX33T2U9pG8bhu5YVR88FQ8OQ0cEsPBpDncg== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Bar: - X-Spamd-Result: default: False [-2.00 / 15.00]; MISSING_MIME_VERSION(2.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[madpilot.net,quarantine]; R_SPF_ALLOW(-0.20)[+mx]; R_DKIM_ALLOW(-0.20)[madpilot.net:s=cyq4qetkgngm]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RECEIVED_HELO_LOCALHOST(0.00)[]; DKIM_TRACE(0.00)[madpilot.net:+] X-Rspamd-Queue-Id: 4cbq2317VGz3kbD List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org On 9/30/25 21:22, Guido Falsi wrote: > On 9/30/25 12:52, Christos Margiolis wrote: >> The branch main has been updated by christos: >> >> URL: https://cgit.FreeBSD.org/src/commit/? >> id=2ffaca551eaf32c17f701762ecf29a961cf19aa4 >> >> commit 2ffaca551eaf32c17f701762ecf29a961cf19aa4 >> Author:     Christos Margiolis >> AuthorDate: 2025-09-30 10:52:44 +0000 >> Commit:     Christos Margiolis >> CommitDate: 2025-09-30 10:52:44 +0000 >> >>      snd_hda: Implement automatic redirection between associations >>      For audio to be redirected to the headphones/headset after >> plugging the >>      jack, or back to the speaker/internal mic when unplugging it, the >>      speaker and headphone pins need to be part of the same association >>      (i.e., the same PCM device). This patch makes it possible to >> redirect >>      audio even between different associations, which can reduce the >> need for >>      manual pin patching. >>      The idea is that we issue a devctl_notify() from within the jack >>      detection callback whenever a jack is (un-)plugged to redirect >> audio to >>      the appropriate device. Then the snd.conf devd script is >> responsible for >>      using virtual_oss to change the playback/recording device to >> whatever >>      snd_hda(4) selected. The reason for requiring virtual_oss is that >> it has >>      hot-swapping support, which is necessary for jack redirection. >>      Sponsored by:   The FreeBSD Foundation >>      MFC after:      2 days >>      Differential Revision:  https://reviews.freebsd.org/D50070 >> --- >>   sbin/devd/Makefile           |  5 +++++ >>   sbin/devd/devd.conf.5        | 16 +++++++++++++ >>   sbin/devd/snd.conf           | 23 +++++++++++++++++++ >>   sys/dev/sound/pci/hda/hdaa.c | 53 ++++++++++++++++++++++++++++++++ >> +----------- >>   4 files changed, 84 insertions(+), 13 deletions(-) >> >> diff --git a/sbin/devd/Makefile b/sbin/devd/Makefile >> index 5d5721d16884..f65eee93dd4b 100644 >> --- a/sbin/devd/Makefile >> +++ b/sbin/devd/Makefile >> @@ -51,6 +51,11 @@ NVMEDIR=        ${DEVDDIR} >>   NVME+=            nvmf.conf >>   NVMEPACKAGE=        nvme-tools >> +CONFGROUPS+=    SND >> +SNDDIR=        ${DEVDDIR} >> +SND+=        snd.conf >> +SNDPACKAGE=    snd > > Looks like this is causing the package building step of the build to > look for a src/release/packages/ucl/snd-all.ucl file. > > Is it intentional to cause this to produce a new base package? > > Looks like in this case an ucl file for the description is needed? > After working around this one locally, I get a similar issue with virtual_oss missing its ucl file too. Just reporting this right away so it is known. -- Guido Falsi