From nobody Sun Apr 12 13:44:20 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ftsGF2lyQz6ZMHJ for ; Sun, 12 Apr 2026 13:44:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ftsGD6VnXz3l6S for ; Sun, 12 Apr 2026 13:44:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776001461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=odCDC46RP51IlO4RYefq3am/UPDx2z3iwUfQSbE2SuU=; b=aqiGWvVQL859+P7Z1IFs+G7l/Dertfi3QpK5JOOkcrUzPjsWL1p1BkRvTQkLu0htKG1KOL Ga9lmA/pGa5UAWOR5Y+mAjKJJg14quSZsl0dMvkJ2KcQuBEuvOENEn75/+uACHXxxesyoe uU8d4hCPPlgDWI1I4qmduFBFxy0YFAw4WEfQqI5QtXLJN7tzO/2VlrRHk8HOQFWH1uV8dJ fY6MvLVPQL7rrlF3kAarHt+xJjZszC9BQp/A2pERhTqKoTv8OGVilWwozNeOxWwVHa1U3R 5U34qFfkrcbpg6hyCGoDCyvz3d7JQ9lAYA1AuvOoboylvv72C+0W6mWNIqfxlw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776001461; a=rsa-sha256; cv=none; b=ggOM+C8goD8P27/v4aYbuDzKb1Xxfy16DHquxF12DTRu32NIwRsLvTaVooJN2rTv5+kZiQ zHpP2H2rZVgxww8cNB6+2TCZ1sS19P/XHHvF1Mem/QJ73nuuP9GO9qSUTWDp+gv4xf/+DC jIiDB0ZLSieGjJaPtU7ti/kEV02kWfGV30ZViGxgwAGg7UWhMfvaoMkK0PBSZYLin8ZiL2 pAMs9+FOpCcaj8LOQgIF4sQDcqsMekpw1sSPP8hYqB3ieBSq1i7CrvLZkIczYID4pMHxSt aEqde3Dby6cdU3RJB4U3JfJAgJu1HtpuOZ2k6XtaJA2rVp/nqvEt77lSPobMHA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776001461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=odCDC46RP51IlO4RYefq3am/UPDx2z3iwUfQSbE2SuU=; b=fpdzabeMbSWk9juL8PPQzmJ/mtuOd8IoSgKz51Cc4MKiNO+uSSR5amIc34td6DyE61ECAk EkD87NMnBwOy52yw2bpPbb2jr8V4TDWWcnksUwQBdQYZ29v9Nzzf1iduL+2GlE5h8hJds5 m9Hrfp1eyqSrVAP9S0g+0UmKWv8G2hXW8nOdePLfkt94cqX1Ia5QM5vaSFrD1zgnPc4FWR lZmW4drraRNPE0r1mQAgmuMiOazYyvOnQvFeM7vYFSsSGCPmPIs2Tix8dSKd3botDRDni3 iVKR+49u9SBYkq46tDwtMoz7WqAra55KuXyXLI/Crt4asLF4Tn0tWFmVjO8nXg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4ftsGD639Kz4Nf for ; Sun, 12 Apr 2026 13:44:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 423cd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 12 Apr 2026 13:44:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Abdelkader Boudih From: Kyle Evans Subject: git: 874d779aa7dd - stable/14 - firmware: Fix inverted FIRMWARE_GET_NOWARN logic List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 874d779aa7ddc8216b06e58ff955adf2a54a17d5 Auto-Submitted: auto-generated Date: Sun, 12 Apr 2026 13:44:20 +0000 Message-Id: <69dba1b4.423cd.77de3348@gitrepo.freebsd.org> The branch stable/14 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=874d779aa7ddc8216b06e58ff955adf2a54a17d5 commit 874d779aa7ddc8216b06e58ff955adf2a54a17d5 Author: Abdelkader Boudih AuthorDate: 2026-01-30 00:02:47 +0000 Commit: Kyle Evans CommitDate: 2026-04-12 13:43:42 +0000 firmware: Fix inverted FIRMWARE_GET_NOWARN logic The try_binary_file() function has inverted logic for the FIRMWARE_GET_NOWARN flag. When the flag is set (meaning "don't warn"), the code sets warn=true and makes noise anyway. Invert the assignment to warn to correctly suppress warnings when FIRMWARE_GET_NOWARN is set. Reviewed by: kevans (cherry picked from commit fdcd67be8274d237ae2c87d6475d9d34b440b8d8) --- sys/kern/subr_firmware.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/subr_firmware.c b/sys/kern/subr_firmware.c index e8f9493decc0..a315209a04cf 100644 --- a/sys/kern/subr_firmware.c +++ b/sys/kern/subr_firmware.c @@ -282,7 +282,7 @@ try_binary_file(const char *imagename, uint32_t flags) int oflags; size_t resid; int error; - bool warn = flags & FIRMWARE_GET_NOWARN; + bool warn = (flags & FIRMWARE_GET_NOWARN) == 0; /* * XXX TODO: Loop over some path instead of a single element path.