Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 7 Oct 2011 23:59:45 +0200
From:      Ulrich =?utf-8?B?U3DDtnJsZWlu?= <uqs@FreeBSD.org>
To:        Nathan Whitehorn <nwhitehorn@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r225951 - head
Message-ID:  <20111007215945.GP26743@acme.spoerlein.net>
In-Reply-To: <201110032046.p93Kkah0027160@svn.freebsd.org>
References:  <201110032046.p93Kkah0027160@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2011-10-03 at 20:46:36 +0000, Nathan Whitehorn wrote:
> Author: nwhitehorn
> Date: Mon Oct  3 20:46:36 2011
> New Revision: 225951
> URL: http://svn.freebsd.org/changeset/base/225951
> 
> Log:
>   Fix a number of platform problems in this file (mostly assuming that only
>   amd64 has lib32).
> 
> Modified:
>   head/ObsoleteFiles.inc
> 
> Modified: head/ObsoleteFiles.inc
> ==============================================================================
> --- head/ObsoleteFiles.inc	Mon Oct  3 20:32:55 2011	(r225950)
> +++ head/ObsoleteFiles.inc	Mon Oct  3 20:46:36 2011	(r225951)
> @@ -56,7 +56,7 @@ OLD_LIBS+=usr/lib/libdwarf.so.2
>  OLD_LIBS+=usr/lib/libopie.so.6
>  OLD_LIBS+=usr/lib/librtld_db.so.1
>  OLD_LIBS+=usr/lib/libtacplus.so.4
> -.if ${TARGET_ARCH} == "amd64"
> +.if ${TARGET_ARCH} == "amd64" || ${TARGET_ARCH} == "powerpc64"
>  OLD_LIBS+=usr/lib32/libcam.so.5
>  OLD_LIBS+=usr/lib32/libpcap.so.7
>  OLD_LIBS+=usr/lib32/libufs.so.5

These conditionals should all be removed. 99% of them are not needed.
The rm(1) should only be conditional on TARGET != arch1 iff arch1 is
still using the file in question. It doesn't matter that arch2 never
ever had that file. It's just one more rm(1) to a non-existing file.

Uli



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111007215945.GP26743>