From owner-svn-src-head@freebsd.org Fri Feb 3 20:26:01 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 47177CCEF71 for ; Fri, 3 Feb 2017 20:26:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0ED3C1C45 for ; Fri, 3 Feb 2017 20:26:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x242.google.com with SMTP id m98so3365255iod.2 for ; Fri, 03 Feb 2017 12:26:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=PNm/6vxbSaOYpJ4dWEjHZYYaviKRz9VLA2rwDvT0NQQ=; b=IM9Ao80b0+U1QfD2JKHJr3RiMLGIqiAgOoq8aCn5a3TRbBfDtRvbvyd7TQe6nYhoMB h/7dl2qaG9/S8jb/fWBSljsLGV4fStkfl7nM70QQYgLnz5MVScDzZQCd5pfUAtt425ih nX2OWwcz2ukyqpHUDygwlm5NuwhiwZdRd1wgBm5diP7TgnTCE1fZeRZqWdaXlOrIU64z dhUdFhN6OS8XbQjV2Y84gp7DiYXWha81KzP8JEnxR8WVfKce2mF1BqN8hQhjkoNEsHFJ uUq8fYwc89vO9/G9nNL94st6/sfNNBErEKrLkmnlrQIZojqzbQPStfR0yi2tvBOkLzPz uIww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=PNm/6vxbSaOYpJ4dWEjHZYYaviKRz9VLA2rwDvT0NQQ=; b=WcdcRvws7Sidcsdc0lMYmw8t/+UEjRaBW4sd2N0/uEj3HMsazkoHmkTK6++JkVvW+n 66XV9Dm7DThpPqlDu0SVKHXAs0gRfbK8FOnx9vuegu4WrwE7m1ga+OOVUBtep0waPRTh Kp5aJyZZhgkoDnN18b1G0fNURgyeaN9pnR8l+JIfR2AvEMEpCBEQsIn7vpxAipRE+Tuc +XrRrq0yL6zScqktbCzpF5Up9LOy1Yp+gYOYiy29r9R/OCc7tXM8axPH1cGYSjutl9ra xKcyggMEfQFzatMjveY/fXeU3iQO5ZCajKPicCCL5L//dTF3eIjAFc2WkqPSwRA1cWZb 1qNg== X-Gm-Message-State: AIkVDXJkOs/+ZhPUdW3t3hD+Dea+WA0LkPs0zh6QvieN3M39MUnV48jvo7EY/AdAek2IiS6JVrgwNhBsjJoSWA== X-Received: by 10.107.139.131 with SMTP id n125mr13027983iod.166.1486153560353; Fri, 03 Feb 2017 12:26:00 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.145.217 with HTTP; Fri, 3 Feb 2017 12:25:59 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: <1486146017.3017.193.camel@freebsd.org> References: <201702031639.v13GdAXQ074031@repo.freebsd.org> <1486140447.3017.189.camel@freebsd.org> <19994E26-42EE-4E12-9867-1E53FA2A7F81@me.com> <1486146017.3017.193.camel@freebsd.org> From: Warner Losh Date: Fri, 3 Feb 2017 13:25:59 -0700 X-Google-Sender-Auth: bA3BXWXgoFG-1d6GGfEowPTF958 Message-ID: Subject: Re: svn commit: r313166 - head/sys/boot/efi/libefi To: Ian Lepore Cc: Toomas Soome , Toomas Soome , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 20:26:01 -0000 On Fri, Feb 3, 2017 at 11:20 AM, Ian Lepore wrote: > On Fri, 2017-02-03 at 18:52 +0200, Toomas Soome wrote: >> > >> > On 3. veebr 2017, at 18:47, Ian Lepore wrote: >> > >> > On Fri, 2017-02-03 at 16:39 +0000, Toomas Soome wrote: >> > > >> > > Author: tsoome >> > > Date: Fri Feb 3 16:39:10 2017 >> > > New Revision: 313166 >> > > URL: https://svnweb.freebsd.org/changeset/base/313166 >> > > >> > > Log: >> > > loader: libefi/env.c warnings in arm build >> > > >> > > The arm build has revealed some of the warnings, the fix for >> > > CHAR16 >> > > warning is to switch the warning off for env.c (same as for >> > > efinet.c). >> > > >> > How is disabling the warning instead of just fixing it the right >> > thing >> > to do? I think disabling a printf format warning is never the >> > right >> > thing to do, it just turns a compile warning into a runtime >> > failure. >> >> I would love to see the correct fix - as all UEFI chars are 2 byte; >> but thats up to arm experts. I just do not know the details why the >> arm is stuck with 4 byte wchar_t there - Im sure they do not have >> this just for fun:) >> >> rgds, >> toomas > > Hmm, looks like the right fix is to add -fshort-wchar to CFLAGS, but > it's got to be consistant across all the libraries that get linked, and > some of them are used in the non-efi case too. I'll have a closer look > at whether we can fix it properly over the next few days. I just wonder why that isn't the default.... And the consistency matters only of wchar_t is used in the library... Lemme know what you come up with... Warner