Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Jan 2020 09:59:29 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 243240] emulators/open-vm-tools-nox11: fails to build after r356337
Message-ID:  <bug-243240-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D243240

            Bug ID: 243240
           Summary: emulators/open-vm-tools-nox11: fails to build after
                    r356337
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: jpaetzel@FreeBSD.org
          Reporter: brigadir15@gmail.com
             Flags: maintainer-feedback?(jpaetzel@FreeBSD.org)
          Assignee: jpaetzel@FreeBSD.org

Created attachment 210586
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D210586&action=
=3Dedit
Remove reference to a_flags field

I'm trying to build emulators/open-vm-tools-nox11 on FreeBSD 13.0-CURRENT
r356200 with /usr/src updated to r356537:

# cd /usr/ports/emulators/open-vm-tools-nox11
# make build
...
--- vfsops.o ---
vfsops.c:212:7: error: too many arguments to function call, expected single
argument 'vp', have 2 arguments
      COMPAT_VOP_UNLOCK(vp, 0, compat_td);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/ports/emulators/open-vm-tools-nox11/work/open-vm-tools-stable-11.0.1/o=
pen-vm-tools/modules/freebsd/shared/compat_vop.h:50:68:
note: expanded from macro 'COMPAT_VOP_UNLOCK'
#define COMPAT_VOP_UNLOCK(vop, flags, threadvar) VOP_UNLOCK((vop), (flags))
                                                 ~~~~~~~~~~        ^~~~~~~
/usr/ports/emulators/open-vm-tools-nox11/work/open-vm-tools-stable-11.0.1/o=
pen-vm-tools/modules/freebsd/vmblock/vnode_if.h:892:1:
note: 'VOP_UNLOCK' declared here
static __inline int VOP_UNLOCK(
^
...

This is caused by r356337[1] which dropped flags argument from VOP_UNLOCK.

I've created a simple patch (with `make makepatch` that fixes the issue for=
 me.

[1] https://svnweb.freebsd.org/base?view=3Drevision&revision=3D356337

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-243240-7788>