Date: Wed, 9 May 2001 13:23:44 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: arch@FreeBSD.org Subject: RE: Patch to eliminate struct pcred Message-ID: <Pine.NEB.3.96L.1010509132233.11741w-100000@fledge.watson.org> In-Reply-To: <XFMail.010509092108.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 9 May 2001, John Baldwin wrote:
> Some comments:
>
> @@ -274,21 +275,31 @@
> ...
> - (p->p_flag & P_TRACED) == 0) {
> + p->p_flag & P_TRACED) {
> ...
>
> It looks like you've inverted the sense of that test.
Oops, nice catch. I've now fixed that.
> What is the XXX: locking comment about here:
>
> @@ -296,25 +307,50 @@
> + p->p_flag &= ~P_SUGID; /* XXX locking */
> PROC_UNLOCK(p);
>
> The process is locked when that flag is cleared.
This is from an earlier incarnation where I had the locking rearranged
some. It no longer applies, so I've removed it.
A patch with those changes (only) is available at:
http://www.watson.org/~robert/pcred.3.diff
Thanks again,
Robert N M Watson FreeBSD Core Team, TrustedBSD Project
robert@fledge.watson.org NAI Labs, Safeport Network Services
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1010509132233.11741w-100000>