From nobody Tue Nov 28 13:38:34 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sfk7H2nSxz52GXs; Tue, 28 Nov 2023 13:38:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sfk7H1Vkyz4Tml; Tue, 28 Nov 2023 13:38:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701178715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uUB4IFg+GpAeL81HJMHcr2lRAmWWN9h4/BUVZXInb1o=; b=nPOVXgC/0HOQl4oPBiUpij7PrRwDmBRglhM5mQ712JzJLDNjzrntZgvK/pKxI14nl4BPhs k61DzYW3rRDvDxpthTrKuAaPlafMOWHhSXFMtb5Ef4CWFJQHYET+ELZYZSIOTaqBfAhWDY Tw8iZef/tz49DRsgJb97+oVsIn6+Zic3yaNSiL5ZFFFQPxzyWZcOXoFUpKcsVRPH8mavnX aTL5crCR2X8WUKgn+yCWC7MsFq/sGj1Xwdm4JMyzgXMlMP1vAlfHaCPny6GskMi2f2crAZ Km3PgXpa6uGdqdph+mYpBwJ/9+MfdRjaulW+QtHFB/Ffjd7ehiBxbta3HuVUDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701178715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uUB4IFg+GpAeL81HJMHcr2lRAmWWN9h4/BUVZXInb1o=; b=Rr0kw1oJ+kKr9fznFnPJ7qDPvyhlrwa78OAlVhX2fJOQVM/MD2CupYpinx1V/KgUzNfEYI Ukr71bmJoVZG3z6H45pxbgkM4oq1UBRCMBeiJGsAWrNk+lwBryKBPlCdNaKEj2SZK+PJG0 GFlTp4VEx0V3E3m62Z02gYLKFXmnLqvJHCbFwlh/5lWuyy1YLLTgop1palRaCeb3SHg9eI PxItoIMejReVchW4VzrYwNyP+PWp7ALkcyEEhik4o89IRiW1/jPo/36xWwfHcP+ccNPsf2 4UVKlGaNNupxAcii7OiR8zYQOFCe1AmIBe0FEVynLEB/ngVddTZAzxpHE+kwDg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701178715; a=rsa-sha256; cv=none; b=o4/QptMXSfIYAO1rtdAQkgGONoUwHUH6SSMnis0/HMPZrgKgJ7r98ucX87vC/aTXSjZJMw ry61FA4Uhm2xu/u7IYwAIjYOQ1Ycm5UU3f8WHNe6X2mQJVvlM37ll7N5eb2wVnDct0ECcq UNOIpmi57PqIKqOzSHQ/y6Bw78YHo9fUkU92c1hsbD2kSLw/sQm3XqmLJMouPibFk4HX13 De6jBUxuO7F5OwusUEuzMdI+1BAG4qu3H63tJ87FSGgBz3AkKIwXWHc/d55C2L627WLQ1G lbOFIICtRq7pkMKNLGONwTnJrEF5cKjN+EWytN1tFt2x1XtqdY0m1erCI6zEuQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Sfk7H0cfwz7rM; Tue, 28 Nov 2023 13:38:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3ASDcYUD025327; Tue, 28 Nov 2023 13:38:34 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3ASDcYjd025324; Tue, 28 Nov 2023 13:38:34 GMT (envelope-from git) Date: Tue, 28 Nov 2023 13:38:34 GMT Message-Id: <202311281338.3ASDcYjd025324@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Roger Pau =?utf-8?Q?Monn=C3=A9?= Subject: git: 54a0b7203c30 - main - xen/apic: remove passing trapframe as argument List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: royger X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 54a0b7203c30bfa5134ffc21f01c2e106f15e842 Auto-Submitted: auto-generated The branch main has been updated by royger: URL: https://cgit.FreeBSD.org/src/commit/?id=54a0b7203c30bfa5134ffc21f01c2e106f15e842 commit 54a0b7203c30bfa5134ffc21f01c2e106f15e842 Author: Elliott Mitchell AuthorDate: 2021-10-08 21:43:26 +0000 Commit: Roger Pau Monné CommitDate: 2023-11-28 12:22:30 +0000 xen/apic: remove passing trapframe as argument While otherwise a handy potential approach, getting the trapframe via the argument isn't documented and isn't supposed to be used. While ipi_bitmap_handler() and ipi_swi_handler() need to be passed the trapframe as their arguments, the Xen functions can retrieve it from curthread->td_intr_frame, which is the proper way. Reviewed by: royger --- sys/x86/xen/xen_apic.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sys/x86/xen/xen_apic.c b/sys/x86/xen/xen_apic.c index db2358bffa81..4f2b03879227 100644 --- a/sys/x86/xen/xen_apic.c +++ b/sys/x86/xen/xen_apic.c @@ -216,10 +216,8 @@ xen_pv_lapic_ipi_vectored(u_int vector, int dest) static int xen_ipi_bitmap_handler(void *arg) { - struct trapframe *frame; - frame = arg; - ipi_bitmap_handler(*frame); + ipi_bitmap_handler(*curthread->td_intr_frame); return (FILTER_HANDLED); } @@ -297,9 +295,8 @@ xen_cpususpend_handler(void *arg) static int xen_ipi_swi_handler(void *arg) { - struct trapframe *frame = arg; - ipi_swi_handler(*frame); + ipi_swi_handler(*curthread->td_intr_frame); return (FILTER_HANDLED); }