From owner-svn-src-head@freebsd.org Wed Dec 5 20:36:23 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8F2541326C83; Wed, 5 Dec 2018 20:36:23 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by mx1.freebsd.org (Postfix) with ESMTP id 47CE66AB4D; Wed, 5 Dec 2018 20:36:18 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au [110.21.101.228]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 9207D105419D; Thu, 6 Dec 2018 07:36:09 +1100 (AEDT) Date: Thu, 6 Dec 2018 07:36:08 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Bruce Evans cc: Alan Somers , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r341598 - head/lib/libc/sys In-Reply-To: <20181206062019.I3775@besplex.bde.org> Message-ID: <20181206072628.M4013@besplex.bde.org> References: <201812051728.wB5HSes8099327@repo.freebsd.org> <20181206062019.I3775@besplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=DZtnkrlW c=1 sm=1 tr=0 a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17 a=kj9zAlcOel0A:10 a=0pmM3Sw-5W8GaYEX4bUA:9 a=CjuIK1q_8ugA:10 X-Rspamd-Queue-Id: 47CE66AB4D X-Spamd-Result: default: False [-6.48 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[optusnet.com.au]; R_SPF_ALLOW(-0.20)[+ip4:211.29.132.0/23]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[optusnet.com.au]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[extmail.optusnet.com.au]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; IP_SCORE(-3.19)[ip: (-8.47), ipnet: 211.28.0.0/14(-4.14), asn: 4804(-3.31), country: AU(-0.04)]; FREEMAIL_TO(0.00)[optusnet.com.au]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[optusnet.com.au]; ASN(0.00)[asn:4804, ipnet:211.28.0.0/14, country:AU]; RCVD_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_LOW(-0.10)[249.132.29.211.list.dnswl.org : 127.0.5.1] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2018 20:36:23 -0000 On Thu, 6 Dec 2018, Bruce Evans wrote: > On Wed, 5 Dec 2018, Alan Somers wrote: > >> Log: >> stat(2): clarify which syscalls modify file timestamps >> ... > > These fields shouldn't exist. They are misimplemented compatibility cruft. > ... > which I fixed in FreeBSD-5 using bit-fields. Now the support for POSIX > before about 2007 is broken by declaring struct timespec undonditionally > and using it for st_atim, etc. API compatibility with old versions of > FreeBSD is broken by renaming st_atimespec to st_atim, etc. API compatibility with old versions of FreeBSD is actually preserved using another macro hack (define st_atimespec as st_atime, etc.). This uses a correct visibility ifdef, but the man page says that it uses a different, incorrect one. The man page only attempts to document the ifdef tangles for st_*tim*. > ... Bruce