From owner-freebsd-current@FreeBSD.ORG  Sat May 22 10:22:42 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0232D16A4CE
	for <current@freebsd.org>; Sat, 22 May 2004 10:22:42 -0700 (PDT)
Received: from root.org (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id C323943D1F
	for <current@freebsd.org>; Sat, 22 May 2004 10:22:41 -0700 (PDT)
	(envelope-from nate@root.org)
Received: (qmail 58679 invoked by uid 1000); 22 May 2004 17:21:59 -0000
Date: Sat, 22 May 2004 10:21:59 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Tim Robbins <tjr@freebsd.org>
In-Reply-To: <20040522040750.GA1345@cat.robbins.dropbear.id.au>
Message-ID: <20040522102026.G58631@root.org>
References: <20040521112116.GA751@cat.robbins.dropbear.id.au>
	<20040521151505.GA1784@cat.robbins.dropbear.id.au>
	<20040522040750.GA1345@cat.robbins.dropbear.id.au>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: current@freebsd.org
Subject: Re: ACPI breakage
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 May 2004 17:22:42 -0000

On Sat, 22 May 2004, Tim Robbins wrote:
> On Sat, May 22, 2004 at 01:15:05AM +1000, Tim Robbins wrote:
> > On Fri, May 21, 2004 at 10:43:01AM -0400, John Baldwin wrote:
> >
> > > On Friday 21 May 2004 07:21 am, Tim Robbins wrote:
> > > > Hi,
> > > >
> > > > On trying to boot a recent CURRENT kernel on one of my machines (i386
> > > > kernel, Pentium III (Katmai) 500 MHz CPU, Abit BH6 motherboard), I get a
> > > > panic: ...
> > > > pcib1: <PCI-PCI bridge> at device 1.0 on pci0
> > > > pci1: <ACPI PCI bus> on pcib1
> > > > pcib0: slot 1 INTA is routed to irq 12
> > > > pcib1: slot 0 INTA is routed to irq 12
> > > >
> > > > Fatal trap 12: page fault while in kernel mode
> > > > fault virtual address = 0x15
> > >
> > > You shouldn't have an ACPI PCI bus as the child of a PCI bus.  What happens if
> > > you revert rev 1.65 of sys/dev/acpica/acpivar.h?
> >
> > It turns out that I reverted acpivar.h to rev. 1.64 when I reverted
> > acpi_ec.c to 1.47. I'll try acpi_ec.c 1.49 + acpivar.h 1.64 and report
> > back on the results.
>
> Just following up on this: I built two otherwise identical kernels, one with
> acpivar.h revision 1.64, and one with revision 1.65. The kernel with 1.64
> worked fine, but the kernel with 1.65 panicked while probing PCI busses.

Reverted.  Thanks to you and peadar@ for testing this.  I'm sorry I didn't
address this earlier (was out of town).  The EC should be fine but the bus
accessor macros were not correct.  I'm very sorry to cause this trouble.

-Nate