From owner-svn-src-all@freebsd.org Fri Jan 18 00:42:06 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D3EF148690E for ; Fri, 18 Jan 2019 00:42:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 732228E2D7 for ; Fri, 18 Jan 2019 00:42:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x744.google.com with SMTP id 189so7149573qkj.8 for ; Thu, 17 Jan 2019 16:42:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=00MgM50rGdtSbWiq9CVjIX9gdy0oZkLGdwOCLIaKpm4=; b=Ez2C2Mn9Rp7hvS5MWLqqMw9ZT8VpbrxBio2a0S0B5THZrUsv0eb+pjxmhKPdhXSk2E Z8nGpNNi4W9JoNUlF+sRrpX3wGTMx0jOt1vLLLWPVK4ddmwJHpeAlHzO9h1fYKIoPk3g iJYVCNaw992826b8ueXhZwXyeTbMcEoA+WcD1kAK27JFbgvL9M88tT11Ssf3SlKnXUMk iXKPnou3K2I8WcqAkgCeRMkmXraJFha/gZ8Ijkxc1nGbHUV+cs37OonBU6wyS7YUf1p7 6nI9pTEm9u4Fsjz14MS5QxEQp3QT3veOFYPhC3ySSc8HyUtm8ho6WEW2a9EjD6IGVhzI PsFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=00MgM50rGdtSbWiq9CVjIX9gdy0oZkLGdwOCLIaKpm4=; b=s6lWKQOsESs726B9es4IKsyratZnu0d2Vf00D7/1nuURclHwxFlrYqWu3zdDpAI8NY qtf/ZFJ8q7v5QYCQh81uxxrJJ1BvB5x7SnSeOtorRUnrWjNST9FJZuvHEz6RcZhwG+zE X7jYloe1kd3o/E/xsTE+AsTnDze1hEsAuGQ5o/MtVIqkWCTVg1sIs0Rq0nsDm7fnDq9P 76QWxA9KrkfmktF6yml+SCuGKDYXqzktzJGe/4jPXalobuA+pf1YldLK/b+ee/QGHTzx peOYC8abjsvJLil6995Gx450I86pHuGp3myyQ1X9fFU9anXBMz/oPn7Ix9Qu2ZOvrIsh rLTQ== X-Gm-Message-State: AJcUukccjXFqabOwyVh+uemlN73/w67MbVv9DZbytwp4vQrudKxvjBjg 9wRJvYn2beZsDc4eBxkhYPVwvTM6NX9GtlKoX0MnSA== X-Google-Smtp-Source: ALg8bN6lyQM0IiSuyLciyPsuS/EmvaBHDbrVBozquuAT0gIcrD3C3J6xlEnFJrB/qMZ/AM1cHlu0BKdYRn7ZPV1glgM= X-Received: by 2002:a37:6c05:: with SMTP id h5mr13072995qkc.175.1547772124804; Thu, 17 Jan 2019 16:42:04 -0800 (PST) MIME-Version: 1.0 References: <201901171808.x0HI80jC068564@repo.freebsd.org> <2d239dc0-915c-2d2b-0936-a40af5e9ead9@freebsd.org> In-Reply-To: From: Warner Losh Date: Thu, 17 Jan 2019 17:41:53 -0700 Message-ID: Subject: Re: svn commit: r343118 - in head/usr.sbin: . trim To: "Conrad E. Meyer" Cc: Eugene Grosbein , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 732228E2D7 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jan 2019 00:42:06 -0000 On Thu, Jan 17, 2019 at 3:43 PM Conrad Meyer wrote: > On Thu, Jan 17, 2019 at 1:16 PM Eugene Grosbein wrote= : > > > > 18.01.2019 3:23, Conrad Meyer =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > > > Please back it out; stop attributing code review to "hackers@," which > > > can not (it's a list, not individuals) and did not review this > > > changeset; and put it on phabricator for actual review. > > > > There is already https://reviews.freebsd.org/D18380 by imp > > and there were over 6 weeks since it had an update. > > Newly committed code has most of its changes. > > Your response does not address *any* of the above concerns. It's just > unrelated. > Yes. > The review you linked to isn't one you submitted for this change; it's > Warner's, and that one stalled because you were such a jerk to him > last time that he needed time off from you. > I abandoned it because dd is the better way to go because it can transfer images with 0's and TRIM the zero'd pages (and only the zero'd pages). Sure dd is hard to use, but it's not that hard to use. > If you want to socialize, revive, or expedite someone else's review, > maybe add a new comment to the review, or post a discussion hackers@, > or something like that. You still can't attribute code review to > hackers@, especially as no such review happened. > I think it should be backed out. Especially since it hijacks my work and my name to try to ram it into the tree. I'm very much not amused. Warner