From owner-svn-src-all@FreeBSD.ORG Fri Aug 13 01:10:43 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8ED971065670; Fri, 13 Aug 2010 01:10:43 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id C086D8FC1D; Fri, 13 Aug 2010 01:10:42 +0000 (UTC) Received: by ewy26 with SMTP id 26so1215063ewy.13 for ; Thu, 12 Aug 2010 18:10:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:content-type:content-transfer-encoding; bh=iZaufVm/yS5rUlzmMXGWuzccRtAHjW+7VhUB30SDIAI=; b=u7dp+vY6UwpHxlerJEdfCRVjTqOM321Le7p6X9Xr835htO32DtW5NTEzJPcbA8d4m2 irtHloLNiedSMpdNEpDGJ0IXABqS/f9rzZstRYuOX7UqpZEJzK4JnWI6Z1h2T1oRtYXu sf/fJXz1yLBQdbLEw244lw6lLwXt2v0adSB9c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=J2e+7YhdS++JuD+PgvJdv4H5VjM6DWzv/8TmrLzcWQE+kWkxm/ZlTdASZJJIRnVa9U vy5jotFcpiyP2YpvuIDSklqjPA87Rvr2S3yMyiJy54vSAjgpCHsjvqueApwrJdM2Vczz jFz9JSViL/FXiUYXHMMAwD21BvXBu8wCGF5GA= MIME-Version: 1.0 Received: by 10.213.8.200 with SMTP id i8mr1096654ebi.18.1281661841499; Thu, 12 Aug 2010 18:10:41 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.213.112.140 with HTTP; Thu, 12 Aug 2010 18:10:41 -0700 (PDT) In-Reply-To: <201008121416.o7CEGvEl002947@svn.freebsd.org> References: <201008121416.o7CEGvEl002947@svn.freebsd.org> Date: Fri, 13 Aug 2010 09:10:41 +0800 X-Google-Sender-Auth: 644Azry8PI1RQNszxrxNKsKQxTQ Message-ID: From: Adrian Chadd To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Subject: Re: svn commit: r211222 - head/usr.sbin/crunch/crunchide X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Aug 2010 01:10:43 -0000 On 12 August 2010 22:16, Adrian Chadd wrote: > =A0I used the wrong type when setting st_name in the symbol table entry > =A0struct. It's an Elf64_Word which is defined as an unsigned 32 bit int > =A0on both 32 and 64 bit platforms. > > =A0To make things sensible, define some new macros to use as "word" macro= s > =A0and use those, rather than simply using the explicit 32 bit macros. .. and I haven't gone over the source with a fine tooth comb to substitute the "right" macros everywhere. It's possible things are still not "correct" but work fine. Adrian