From owner-svn-ports-head@freebsd.org  Wed Mar 15 08:35:59 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C3A27D0C134;
 Wed, 15 Mar 2017 08:35:59 +0000 (UTC) (envelope-from tz@FreeBSD.org)
Received: from toco-domains.de (mail.toco-domains.de [176.9.39.170])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8EB941E62;
 Wed, 15 Mar 2017 08:35:58 +0000 (UTC) (envelope-from tz@FreeBSD.org)
Received: from [0.0.0.0] (mail.toco-domains.de [IPv6:2a01:4f8:150:50a5::6])
 by toco-domains.de (Postfix) with ESMTPA id 48C791AAF058;
 Wed, 15 Mar 2017 09:35:51 +0100 (CET)
Subject: Re: svn commit: r436164 - in head/www/gitlab: . files
To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org,
 Remko Lodder <remko@freebsd.org>
References: <201703141639.v2EGdVx9035112@repo.freebsd.org>
 <0cba26e2-c939-f205-59b3-04d30577a361@FreeBSD.org>
From: Torsten Zuehlsdorff <tz@FreeBSD.org>
Message-ID: <e6c16ef5-85bb-1597-ef25-fa1ae5e8bf5c@FreeBSD.org>
Date: Wed, 15 Mar 2017 09:35:51 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <0cba26e2-c939-f205-59b3-04d30577a361@FreeBSD.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Mar 2017 08:35:59 -0000



On 14.03.2017 21:22, Mathieu Arnold wrote:
> Le 14/03/2017 à 17:39, Torsten Zuehlsdorff a écrit :
>> +OPTIONS_SINGLE=	DATABASE
>> +OPTIONS_SINGLE_DATABASE=	PGSQL MYSQL
>> +OPTIONS_DEFAULT=	PGSQL
>> +PGSQL_DESC=	Default PostgreSQL support (preferred)
>> +MYSQL_DESC=	Optional MySQL support
>
> Would it be possible to make that an OPTIONS_MULTI or OPTIONS_GROUP so
> that both can be selected or none (for generic packaging)

Not really useful, no.

If none is selected, GitLab won't work at all.
If MYSQL is selected, GitLab has known issues.
If PGSQL is selected, everything is fine.

There are some users who prefer to use MYSQL and can cope with the 
consequences. Any other should use just PostgreSQL. Therefore the choice 
of SINGLE.

Also every option modifies the Gemfile when selected. So even with 
MULTI, the user would need to manually patch GitLab to be able to start.

Greetings,
Torsten