From owner-svn-src-all@FreeBSD.ORG Thu Jan 13 23:00:22 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 897A1106564A; Thu, 13 Jan 2011 23:00:22 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 78A1A8FC08; Thu, 13 Jan 2011 23:00:22 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id p0DN0MuG066580; Thu, 13 Jan 2011 23:00:22 GMT (envelope-from kib@svn.freebsd.org) Received: (from kib@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id p0DN0MAo066578; Thu, 13 Jan 2011 23:00:22 GMT (envelope-from kib@svn.freebsd.org) Message-Id: <201101132300.p0DN0MAo066578@svn.freebsd.org> From: Konstantin Belousov Date: Thu, 13 Jan 2011 23:00:22 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r217383 - head/lib/csu/i386-elf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jan 2011 23:00:22 -0000 Author: kib Date: Thu Jan 13 23:00:22 2011 New Revision: 217383 URL: http://svn.freebsd.org/changeset/base/217383 Log: The (%esp & 0xf) == 0 should be true before the call instruction is executed, for the properly aligned stack. Reported and tested by: rstone Pointy hat to: kib MFC after: 3 days Modified: head/lib/csu/i386-elf/crt1_s.S Modified: head/lib/csu/i386-elf/crt1_s.S ============================================================================== --- head/lib/csu/i386-elf/crt1_s.S Thu Jan 13 22:52:57 2011 (r217382) +++ head/lib/csu/i386-elf/crt1_s.S Thu Jan 13 23:00:22 2011 (r217383) @@ -42,6 +42,7 @@ _start: .cfi_def_cfa_register %ebp andl $0xfffffff0,%esp # align stack leal 8(%ebp),%eax + subl $4,%esp pushl %eax # argv pushl 4(%ebp) # argc pushl %edx # rtld cleanup