From owner-freebsd-ports-bugs@freebsd.org Wed Jul 19 14:00:52 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CAA5BC7E22B for ; Wed, 19 Jul 2017 14:00:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B8F2B805FE for ; Wed, 19 Jul 2017 14:00:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v6JE0q0q063492 for ; Wed, 19 Jul 2017 14:00:52 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 220548] Mk/Scripts/cargo-crates.awk: "make cargo-crates" doesn't strip branch name Date: Wed, 19 Jul 2017 14:00:52 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tobik@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2017 14:00:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220548 --- Comment #5 from commit-hook@freebsd.org --- A commit references this bug: Author: tobik Date: Wed Jul 19 14:00:17 UTC 2017 New revision: 446198 URL: https://svnweb.freebsd.org/changeset/ports/446198 Log: When specifying Git dependencies in Cargo.toml developers can set 3 additional keys: rev, branch, tag [1]. These are reflected in a projects' Cargo.lock file as e.g. =20 git+https://github.com/servo/angle?branch=3Dservo#a1371e8a160128677af863d1d= 73f150862ba42b2 =20 git+https://github.com/rust-lang/libc?tag=3D0.2.26#288942e6858a4b2f8ee56338= da5386263b9c4b82 Currently cargo-crates.awk generates the wrong output in these cases: GH_TUPLE=3D=20=20=20=20 servo:angle?branch=3Dservo:a1371e8a160128677af863d1d73f150862ba42b2:angle \ =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 rust-lang:libc?tag=3D0.2.26:288942e6858a4b2f8ee56338da5386263b9c4b82:libc Fix cargo-crates.awk to ignore the query string (except in the tag case) and generate GH_TUPLE=3D servo:angle:a1371e8a160128677af863d1d73f150862ba42b2:angl= e \ rust-lang:libc:0.2.26:libc instead. [1] https://github.com/rust-lang/cargo/blob/master/src/doc/specifying-dependenc= ies.md#specifying-dependencies-from-git-repositories PR: 220548 Reported by: jbeich Reviewed by: jbeich, mat Differential Revision: https://reviews.freebsd.org/D11571 Changes: head/Mk/Scripts/cargo-crates.awk --=20 You are receiving this mail because: You are on the CC list for the bug.=