From owner-svn-src-head@freebsd.org Fri Mar 15 17:07:38 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F8E815271A4 for ; Fri, 15 Mar 2019 17:07:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3A8C7717AB for ; Fri, 15 Mar 2019 17:07:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72b.google.com with SMTP id k189so681978qkc.0 for ; Fri, 15 Mar 2019 10:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N8scpET9Kw5o4pdF8nVjMr6w0TX6wL42UMwhjDdQ/bQ=; b=2ENTcAaWkWqRKhxJYWXBIWBq3ew8lY/5PNPWknu3XXx9R9frb2ZIGSF6FwJYwKw1qb ntPtPBdrQK+4+0pAKbzm5D7UxclqjoUOpu7VwlWwM5mW3eDfqBM8l3iLMlWS0B9GHm1m k6/5A5A2JdvLo11jfpgsnTmIS3tMEKQcwZgWePo0Fk4ON4tRsH6Z0d8S6taJrByOiGNV +n8yokAjrWqriuJsKQxGazgsIUJ4Cqjka5lG6SL9zZa6aQl2Kt4NtAylphPHjsVW5FOf icYtAZaB7x7tBjNvhlS02kknDHQLrHS8AgvizkpbySpR7m/5KqFE+ClF4VgClweeABg6 antg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N8scpET9Kw5o4pdF8nVjMr6w0TX6wL42UMwhjDdQ/bQ=; b=MUhvOn+fdxXhqXOu6Gtik9bjq3uk1AvLjGYIKNWXlFQSZa4T5YPAfUbj7nrdujArUE GBJqobdXg4qvGFI32XUjifCgI0QnGtgJF9z87yjaGoeqKuK4dEqlHhUCVpA2PFCxxi2J /F6eZ409wU8ZwRghI9ALK5erZDwIgFgFJCd2sU4tlV0wr5mSEVL5wUjk4vDI9nxIVH27 huOciQ/upAbWTnUDLFVNvB3G5qFnkMAYmTxkPZlpvo/5X/lKNVH1FXg0435GhoezqB5b T+JSgCVOREr/YZgH8Z0184FqNyGBbopgsvYQs8qieS06rM43i/mK/gnlsz0A6RWiqbpV TihA== X-Gm-Message-State: APjAAAU81UPHsh+CO9nlJ4dZpYZPMWkkvnLS6ZCKXmZ7AY3O17Fhqx1j HDi1ftHjuQVEh3a7ZOU9yALVoox0V1rlOLGaA19XUA== X-Google-Smtp-Source: APXvYqwMXDVXN8MQre1nni6T9PW9L6Kc6t7BXaGkRQcru4Y+SSfXThX2Z188LmDjELwIGGCRJ9dun3AFrr+k40cJD3A= X-Received: by 2002:a37:6fc2:: with SMTP id k185mr3693142qkc.175.1552669657382; Fri, 15 Mar 2019 10:07:37 -0700 (PDT) MIME-Version: 1.0 References: <201903151556.x2FFuAA4030779@gndrsh.dnsmgr.net> In-Reply-To: <201903151556.x2FFuAA4030779@gndrsh.dnsmgr.net> From: Warner Losh Date: Fri, 15 Mar 2019 11:07:26 -0600 Message-ID: Subject: Re: svn commit: r345171 - head/usr.sbin/bhyve To: "Rodney W. Grimes" Cc: Chuck Tuffli , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 3A8C7717AB X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 17:07:39 -0000 On Fri, Mar 15, 2019 at 9:56 AM Rodney W. Grimes wrote: > > On Thu, Mar 14, 2019 at 8:32 PM Rodney W. Grimes < > freebsd@gndrsh.dnsmgr.net> > > wrote: > > > > > > Author: chuck > > > > Date: Fri Mar 15 02:11:28 2019 > > > > New Revision: 345171 > > > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > > > > > Log: > > > > Fix bhyve PCIe capability emulation > > > > > > > > PCIe devices starting with version 1.1 must set the Role-Based > Error > > > > Reporting bit. > > > > > > > > And while we're in the neighborhood, generalize the code assigning > the > > > > device type. > > > > > > > > Reviewed by: imp, araujo, rgrimes > > > > Approved by: imp (mentor) > > > > MFC after: 1 week > > > > Differential Revision: https://reviews.freebsd.org/D19580 > > > > > > This code requires maintainer approval before a commit, > > > though this was well reviewed that doesnt exclude it > > > from the MAINTAINERS entry. > > > > > > Leave it for now, I am sure jhb or thyco are fine with it, > > > this is just a heads up FYI for future commits. > > > > > > Bhyve code has been and still is under a fairly tight > > > MAINTAINER status. > > > > > > > There is no such thing as a hard lock in FreeBSD. This sounds like you > are > > advocating for that, but that's not the case. > > > > Stop this stupid nitpicking for single line commits. We don't have that > > culture any more and it's really pissing a lot of people off. > > > > The MAINTAINERS file even says this: > > > > Please note that the content of this file is strictly advisory. > > > > And the entry for bhyve doesn't say things are mandatory, just requested. > > > > Jumping on people's case like this, for a review you yourself were on and > > approved but made no mention of seeking further review / approval, is > > demotivating and toxic. Please stop. > > I explicitly DID add jhb to the review. > I also explicitly did not mark the bhyve# box that is added by > the hearald rules. > > I did not jump on him, I informed him of the entry, and told him to leave > it. > You how ever have infact jumped on me, repeatedly, if you want to talk > about > discouraging tones of behavior I suggest you look at yourself as well. > Weird that so many other people in the thread read it the same way that I did, and not only this time. That suggests that you're not aware that your behavior is annoying others, which I contend is a problem that needs looking into. As always, I'm open to constructive, actionable feedback about my actions. Warner > > Warner > > > > > head/usr.sbin/bhyve/pci_emul.c > > > > > > > > Modified: head/usr.sbin/bhyve/pci_emul.c > > > > > > > > ============================================================================== > > > > --- head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:27 2019 > > > (r345170) > > > > +++ head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:28 2019 > > > (r345171) > > > > @@ -953,7 +953,10 @@ pci_emul_add_pciecap(struct pci_devinst *pi, int > > > type) > > > > bzero(&pciecap, sizeof(pciecap)); > > > > > > > > pciecap.capid = PCIY_EXPRESS; > > > > - pciecap.pcie_capabilities = PCIECAP_VERSION | > PCIEM_TYPE_ROOT_PORT; > > > > + pciecap.pcie_capabilities = PCIECAP_VERSION | type; > > > > + /* Devices starting with version 1.1 must set the RBER bit */ > > > > + if (PCIECAP_VERSION >= 1) > > > > + pciecap.dev_capabilities = PCIEM_CAP_ROLE_ERR_RPT; > > > > pciecap.link_capabilities = 0x411; /* gen1, x1 */ > > > > pciecap.link_status = 0x11; /* gen1, x1 */ > > > > > > > > > > > > > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > > > > -- > Rod Grimes > rgrimes@freebsd.org >