Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Dec 2012 04:28:05 +0000 (UTC)
From:      Adrian Chadd <adrian@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r244529 - head/sys/dev/ath/ath_hal/ar5416
Message-ID:  <201212210428.qBL4S5fP088624@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: adrian
Date: Fri Dec 21 04:28:05 2012
New Revision: 244529
URL: http://svnweb.freebsd.org/changeset/base/244529

Log:
  Note why fast frames is disabled for 802.11n NICs now.
  
  It actually works, but net80211 handles A-MPDU and Fast frames
  incorrectly; it tries enabling both in some instances, with tragic
  results.

Modified:
  head/sys/dev/ath/ath_hal/ar5416/ar5416_attach.c

Modified: head/sys/dev/ath/ath_hal/ar5416/ar5416_attach.c
==============================================================================
--- head/sys/dev/ath/ath_hal/ar5416/ar5416_attach.c	Fri Dec 21 02:42:35 2012	(r244528)
+++ head/sys/dev/ath/ath_hal/ar5416/ar5416_attach.c	Fri Dec 21 04:28:05 2012	(r244529)
@@ -898,7 +898,13 @@ ar5416FillCapabilityInfo(struct ath_hal 
 
 	pCap->halCompressSupport = AH_FALSE;
 	pCap->halBurstSupport = AH_TRUE;
-	pCap->halFastFramesSupport = AH_FALSE;	/* XXX? */
+	/*
+	 * This is disabled for now; the net80211 layer needs to be
+	 * taught when it is and isn't appropriate to enable FF processing
+	 * with 802.11n NICs (it tries to enable both A-MPDU and
+	 * fast frames, with very tragic crash-y results.)
+	 */
+	pCap->halFastFramesSupport = AH_FALSE;
 	pCap->halChapTuningSupport = AH_TRUE;
 	pCap->halTurboPrimeSupport = AH_TRUE;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201212210428.qBL4S5fP088624>