From owner-svn-src-all@FreeBSD.ORG  Fri Dec 21 04:28:06 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 350F32C8;
 Fri, 21 Dec 2012 04:28:06 +0000 (UTC)
 (envelope-from adrian@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 by mx1.freebsd.org (Postfix) with ESMTP id 1A3A08FC16;
 Fri, 21 Dec 2012 04:28:06 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
 by svn.freebsd.org (8.14.5/8.14.5) with ESMTP id qBL4S50E088625;
 Fri, 21 Dec 2012 04:28:05 GMT (envelope-from adrian@svn.freebsd.org)
Received: (from adrian@localhost)
 by svn.freebsd.org (8.14.5/8.14.5/Submit) id qBL4S5fP088624;
 Fri, 21 Dec 2012 04:28:05 GMT (envelope-from adrian@svn.freebsd.org)
Message-Id: <201212210428.qBL4S5fP088624@svn.freebsd.org>
From: Adrian Chadd <adrian@FreeBSD.org>
Date: Fri, 21 Dec 2012 04:28:05 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r244529 - head/sys/dev/ath/ath_hal/ar5416
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2012 04:28:06 -0000

Author: adrian
Date: Fri Dec 21 04:28:05 2012
New Revision: 244529
URL: http://svnweb.freebsd.org/changeset/base/244529

Log:
  Note why fast frames is disabled for 802.11n NICs now.
  
  It actually works, but net80211 handles A-MPDU and Fast frames
  incorrectly; it tries enabling both in some instances, with tragic
  results.

Modified:
  head/sys/dev/ath/ath_hal/ar5416/ar5416_attach.c

Modified: head/sys/dev/ath/ath_hal/ar5416/ar5416_attach.c
==============================================================================
--- head/sys/dev/ath/ath_hal/ar5416/ar5416_attach.c	Fri Dec 21 02:42:35 2012	(r244528)
+++ head/sys/dev/ath/ath_hal/ar5416/ar5416_attach.c	Fri Dec 21 04:28:05 2012	(r244529)
@@ -898,7 +898,13 @@ ar5416FillCapabilityInfo(struct ath_hal 
 
 	pCap->halCompressSupport = AH_FALSE;
 	pCap->halBurstSupport = AH_TRUE;
-	pCap->halFastFramesSupport = AH_FALSE;	/* XXX? */
+	/*
+	 * This is disabled for now; the net80211 layer needs to be
+	 * taught when it is and isn't appropriate to enable FF processing
+	 * with 802.11n NICs (it tries to enable both A-MPDU and
+	 * fast frames, with very tragic crash-y results.)
+	 */
+	pCap->halFastFramesSupport = AH_FALSE;
 	pCap->halChapTuningSupport = AH_TRUE;
 	pCap->halTurboPrimeSupport = AH_TRUE;