From owner-svn-src-head@FreeBSD.ORG Sat Jun 4 10:01:49 2011 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B8DEE106564A; Sat, 4 Jun 2011 10:01:49 +0000 (UTC) (envelope-from brix@FreeBSD.org) Received: from solow.pil.dk (relay.pil.dk [195.41.47.164]) by mx1.freebsd.org (Postfix) with ESMTP id 74E148FC1B; Sat, 4 Jun 2011 10:01:49 +0000 (UTC) Received: from druadan.brixandersen.dk (0x55534f5f.adsl.cybercity.dk [85.83.79.95]) by solow.pil.dk (Postfix) with ESMTPA id 961E21CC016; Sat, 4 Jun 2011 12:01:47 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-7-309506294" From: Henrik Brix Andersen In-Reply-To: <4DE9FEC4.4020507@FreeBSD.org> Date: Sat, 4 Jun 2011 12:01:44 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <201105291425.p4TEPggZ033861@svn.freebsd.org> <9F1CE0EF-CCA6-4A8A-8FE1-2E593626025A@FreeBSD.org> <4DE9FEC4.4020507@FreeBSD.org> To: Andreas Tobler X-Pgp-Agent: GPGMail 1.3.3 X-Mailer: Apple Mail (2.1084) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r222449 - in head/sys: conf dev/iicbus powerpc/conf X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jun 2011 10:01:49 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-7-309506294 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi, On Jun 4, 2011, at 11:45, Andreas Tobler wrote: > The chip itself is not PowerMac specific. It contains four times the = functionality of the ad7418 which is already in there. (dev/iicbus) >=20 > The ofw is only needed to detect the chip and to wire the sensor place = to the right fan property. I think this could be refactored that it is = PowerMac only and others could benefit from the driver too. Right. Since iicbus(4) is a hinted bus, I believe the current scenario = could be improved either by having a dynamic hints system (and an OFW = specific layer that added hints about known devices at runtime) or = perhaps an OFW iicbus subclass (didn't Nathan start on this in = r186833?). > The same would apply for the ds1775.c and the max6690.c. Those chips = are not PowerMac only, they are simple i2c temp sensors. Agreed. > To get there, it would really be helpful if there are other people = with non PowerMac hardware who would have an interest in these drivers. > Then we could sit together, refactor and test. W/o the corresponding = hardware it seems a bit difficult for me to test. I'd love to help. I'll try getting my hands on the raw chips and wire = them up to my glxiic(4) based lab setup. I'll get back to you then. Brix --=20 Henrik Brix Andersen --Apple-Mail-7-309506294 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAk3qAogACgkQv+Q4flTiePjYsACgi/0L7Gmxty4Sjs7KVUP0viyq EbsAnRw2jlghTLvJuMuOblsjKe4WD0j0 =Uixd -----END PGP SIGNATURE----- --Apple-Mail-7-309506294--