From owner-svn-src-head@freebsd.org Fri Jun 23 23:51:43 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 381F1D8CD22; Fri, 23 Jun 2017 23:51:43 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0A168792CD; Fri, 23 Jun 2017 23:51:43 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 20B27E673; Fri, 23 Jun 2017 23:51:42 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Date: Fri, 23 Jun 2017 23:51:39 +0000 From: Glen Barber To: Conrad Meyer Cc: Maxim Sobolev , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r320277 - head/usr.bin/mkuzip Message-ID: <20170623235139.GA69426@FreeBSD.org> References: <201706231739.v5NHd05x039900@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0F1p//8PRICkK4MW" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 11.0-STABLE amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event X-PEKBAC-Definition: Problem Exists, Keyboard Between Admin/Computer X-Spidey-Sense: Uh oh, Peter logged in User-Agent: Mutt/1.8.2 (2017-04-18) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2017 23:51:43 -0000 --0F1p//8PRICkK4MW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 23, 2017 at 03:54:35PM -0700, Conrad Meyer wrote: > > @@ -58,12 +59,15 @@ mkuz_get_insize(struct mkuz_cfg *cfp) > > ffd =3D open(statfsbuf.f_mntfromname, O_RDONLY); > > if (ffd < 0) { > > warn("open(%s, O_RDONLY)", statfsbuf.f_mntfromn= ame); > > + close(ffd); >=20 > This one is wrong for obvious reasons. >=20 It isn't obvious to me. :) Glen --0F1p//8PRICkK4MW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAllNqYYACgkQAxRYpUeP 4pPlWA//bu2hZg+SqiYNZFVN0wahfLRoRfTUX7dXC9gX/UdWx2TXg1mRQ+WLHeQW dyUwsA2DfxD6CUsmza2UTT6S22VN00TBgMGl9HfbMOTagPt/VO1IkTbLBPdOk95z zllAJWa/FVdNHIA9ZhpVS1emGCuPivse+wVp22shkg1YEvFBUu3l0qlB2Kgk49LO 1SWmNkkmW8g4EK98d8FwKllV0u/e1gcv8EfdzGqOyH/jsVOGL8zkyup8SJDhPRxg 8F7NpnLSawrTxNXEkd6LIFGAI0m37uNqMpiuJTmjRCjk11VhyJzluPVbFUGCGoDk 9MqjvLhWf2xtzeb7+lMFez2lKoOJRSmJYFddyaCHf8DvAbB530A/9LApOKymG2Vu T8xIH4YbpLsVTJWvdU6NEFC3MBUkqBkvwnXYaQTc8SIY4uhp0OoGkBbdaH1zIofw eJOESQ2z0AZ0oS9rus8xY0X2kjUGcrR7gUAJ5GlmBjzVitoj/P44CASLoZgiGnpx s+UVrtxcnQZN+4HvGGNawdxN5/2Jtr+sbqxQZTz6stnB8DGIuSsAXtrEMAt3GjMJ BAPt4mULhHL+pMTH0RnX7qAuzplBmxJUzoS52q4+tecj7lwKCT9sS0MCMITUvVmS NCb5GE5+UMNjlTjNlFlz75I8u63RDZ1LrqqXTAOR1mk5AvbY97I= =EQVT -----END PGP SIGNATURE----- --0F1p//8PRICkK4MW--