From nobody Thu Dec 7 04:03:29 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sm0xp4C6Nz53WPj for ; Thu, 7 Dec 2023 04:03:42 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sm0xp2Q1Rz3Jvy for ; Thu, 7 Dec 2023 04:03:42 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3332fc9b9b2so466573f8f.1 for ; Wed, 06 Dec 2023 20:03:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701921820; x=1702526620; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1hHJ4TkJrkAADi30knhFunzanv/pRO/dC6KKyWtp8hA=; b=G9D/V2GjKEmCLnBa9xKyNCwH1Iv7ApAjXRi2w5nYACI+d7yAIwzK/vqLYLLguPnDBw L8cArk6TYQ+qb4USdgxklaSoQTxzCYZRqnU8AKTyOneMaFilTGzu2TNarUQFJskH+Wt3 ruj+c4eQX7uSFJAr2qe17a3s0zhXEtbpq0p71C5r2ioKn3EwtMswu6gZiCPNUJBzJrie z4dJRqMvSpD5FeKv2j7gaJI3jqqAJETHBy+Aa3jcw9frOOLIChY/LjAMwN6iibgo8Pgq Pnij/CvLzzWCPw3w4Yy5FXNgPKxKsfQgRUHj9KcaMekeY1zt/rE7gvqEawd+H33sdtVr rgXg== X-Gm-Message-State: AOJu0YwcamFM56cY5Tw6iqlcgsRUDv7q3CAYPGWu6SEAgdcuXQTHozQ/ zVIz7uCmnKCSKLT98nt/Dt1RXQ== X-Google-Smtp-Source: AGHT+IFrmPhw/JniJnGv5hmamQUqSptNeEpcDheefaxaR9DhhWTr7hIGHFk0wN6W1qVo8hETNwkyTA== X-Received: by 2002:adf:e903:0:b0:332:f566:c2 with SMTP id f3-20020adfe903000000b00332f56600c2mr570966wrm.39.1701921820470; Wed, 06 Dec 2023 20:03:40 -0800 (PST) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id t11-20020adfe10b000000b0033363342041sm317363wrz.23.2023.12.06.20.03.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Dec 2023 20:03:39 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Subject: Re: git: 83d0b8c089d8 - main - bsdinstall generate opt_osname.h in include From: Jessica Clarke In-Reply-To: <71239.1701921562@kaos.jnpr.net> Date: Thu, 7 Dec 2023 04:03:29 +0000 Cc: Warner Losh , src-committers , "" , "" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202312070235.3B72ZoZp043061@gitrepo.freebsd.org> <71239.1701921562@kaos.jnpr.net> To: "Simon J. Gerraty" X-Mailer: Apple Mail (2.3774.200.91.1.1) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Spamd-Bar: ---- X-Rspamd-Queue-Id: 4Sm0xp2Q1Rz3Jvy On 7 Dec 2023, at 03:59, Simon J. Gerraty wrote: > Warner Losh wrote: >> Silly question: why not just add it to CFLAGS with >> -DOSNAME=3D\"${OSNAME}\" rather than generating this file? >=20 > Actually it is an excellent question - I've no idea why opt_osname.h = is > needed. To quote the motivation from brd@=E2=80=99s original review: > The reason I did it using a file is so that make(1) would detect a > change a rebuild if you change the value and do another build. -- https://reviews.freebsd.org/D34878#791429 Jess