From owner-svn-src-all@FreeBSD.ORG  Tue Nov 25 10:18:58 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id BE0C64EA;
 Tue, 25 Nov 2014 10:18:58 +0000 (UTC)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
 by mx1.freebsd.org (Postfix) with ESMTP id 7E0F551;
 Tue, 25 Nov 2014 10:18:58 +0000 (UTC)
Received: from nine.des.no (smtp.des.no [194.63.250.102])
 by smtp-int.des.no (Postfix) with ESMTP id 22697AC8B;
 Tue, 25 Nov 2014 10:18:57 +0000 (UTC)
Received: by nine.des.no (Postfix, from userid 1001)
 id 9E8601285; Tue, 25 Nov 2014 11:18:51 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Ermal LuXXi <eri@FreeBSD.org>
Subject: Re: svn commit: r274709 - head/sys/netpfil/pf
References: <201411191331.sAJDV9bH092190@svn.freebsd.org>
 <86tx1nvcy4.fsf@nine.des.no>
Date: Tue, 25 Nov 2014 11:18:51 +0100
In-Reply-To: <86tx1nvcy4.fsf@nine.des.no> ("Dag-Erling =?utf-8?Q?Sm=C3=B8r?=
 =?utf-8?Q?grav=22's?= message of
 "Tue, 25 Nov 2014 10:36:51 +0100")
Message-ID: <86ppcbvb04.fsf@nine.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2014 10:18:58 -0000

Dag-Erling Sm=C3=B8rgrav <des@des.no> writes:
> This is wrong, and causes a panic with some network adapters (vtnet, for
> one).  It is closely related to 192013 and should not have been
> committed without consulting me first.  Please revert, or just #if 0 out
> the entire block since the old code is even more wrong than your
> version.

Note: I am aware that the patch in 192013 is incorrect as well, which is
why I never committed it, although I should have noted that in the PR.
The current IPv4 code is also slightly wrong, but not as much as the
IPv6 code.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no