From owner-svn-ports-all@FreeBSD.ORG  Thu Nov 29 08:27:12 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id BD8B9E7A;
 Thu, 29 Nov 2012 08:27:12 +0000 (UTC)
 (envelope-from martymac@FreeBSD.org)
Received: from lmtp.galacsys.net (webmail.galacsys.net
 [IPv6:2001:1b78:0:1:d918:51d7:0:1])
 by mx1.freebsd.org (Postfix) with ESMTP id 55B938FC13;
 Thu, 29 Nov 2012 08:27:12 +0000 (UTC)
Received: from martymac.org (webmail.galacsys.net [217.24.81.215])
 by lmtp.galacsys.net (Postfix) with ESMTP id 1F6DF1FA5CD3;
 Thu, 29 Nov 2012 09:27:11 +0100 (CET)
From: "Ganael LAPLANCHE" <martymac@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r307891 - in head/benchmarks/bonnie++: . files
X-Openwebmail-Date: Thu, 29 Nov 2012 10:27:11 +0200
Message-Id: <20121129081330.M86834@FreeBSD.org>
In-Reply-To: <20121128092232.GA45503@FreeBSD.org>
References: <201211280826.qAS8QmWu077786@svn.freebsd.org>
 <20121128092232.GA45503@FreeBSD.org>
X-Mailer: Open WebMail 2.01 20030425
X-OriginatingIP: 157.99.64.43 (ganael.laplanche@martymac.org)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Date: Thu, 29 Nov 2012 08:27:12 +0000 (UTC)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Nov 2012 08:27:12 -0000

On Wed, 28 Nov 2012 09:22:32 +0000, Alexey Dokuchaev wrote

Hi Alexey,

> I wonder is it about time to drop this $PTHREAD_LIBS magic?  
> It's been -pthread on all supported versions of FreeBSD for a 
> while now.

+1 for removing $PTHREAD_LIBS if it is not needed anymore.

> Not to mention that in this case actual patch 
> seems overly engineered and not particularly pretty (sorry 
> Ganael).

Oops, you're right, the patch is really ugly ; I could've simply used
REINPLACE_CMD here. I'll fix that (I presume I was too tired when I
worked on it ; thanks for having noticed that).

Best regards,

--
Ganael LAPLANCHE <ganael.laplanche@martymac.org>
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org