From owner-freebsd-bugs  Sun Jun  6  4:20: 3 1999
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 3951515172
	for <freebsd-bugs@FreeBSD.org>; Sun,  6 Jun 1999 04:20:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id EAA50859;
	Sun, 6 Jun 1999 04:20:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from mrelay.jrc.it (mrelay.jrc.it [139.191.1.65])
	by hub.freebsd.org (Postfix) with ESMTP id E4C5814F32
	for <freebsd-gnats-submit@freebsd.org>; Sun,  6 Jun 1999 04:15:10 -0700 (PDT)
	(envelope-from nick.hibma@jrc.it)
Received: from elpc36.jrc.it (elpc36.jrc.it [139.191.71.36])
	by mrelay.jrc.it (LMC5692) with ESMTP id NAA25144
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 6 Jun 1999 13:15:07 +0200 (MET DST)
Received: (from n_hibma@localhost)
	by elpc36.jrc.it (8.9.3/8.8.7) id NAA44376;
	Sun, 6 Jun 1999 13:13:45 +0200 (CEST)
	(envelope-from n_hibma)
Message-Id: <199906061113.NAA44376@elpc36.jrc.it>
Date: Sun, 6 Jun 1999 13:13:45 +0200 (CEST)
From: n_hibma@freebsd.org
Reply-To: n_hibma@freebsd.org
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: misc/12049: [PATCH] searching for closed reports requires two selections
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         12049
>Category:       misc
>Synopsis:       [PATCH] searching for closed reports requires two selections
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun  6 04:20:00 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator:     Nick Hibma
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
>Environment:

	Current web pages at www.freebsd.org
	http://www.freebsd.org/cgi/query-pr-summary.cgi?query

>Description:

	You can select closed in the 'State:' field, but if you want to
	actually see the closed ones you have to select the button 'Closed
	reports too' at the bottom of the page. I suggest moving that button
	up to below the State: field.

	Maybe rename the button to 'Show closed reports too'.

	Other option is to include Closed reports automatically if someone
	asks for state 'Closed'.

	Both patches are included. Use the chunk you like.

>How-To-Repeat:

>Fix:

n_hibma@freefall:cgi% cvs diff query-pr-summary.cgi 
Index: query-pr-summary.cgi
===================================================================
RCS file: /home/ncvs/www/en/cgi/query-pr-summary.cgi,v
retrieving revision 1.22
diff -u -r1.22 query-pr-summary.cgi
--- query-pr-summary.cgi        1999/02/26 22:05:58     1.22
+++ query-pr-summary.cgi        1999/06/06 11:13:37
@@ -203,7 +203,8 @@
 #       [--list-categories] [--list-responsible] [--list-submitters]
 #       [--text=text] [--multitext=mtext] [PR] [PR]...
 
-$query_args .= " --skip-closed" unless $input{"closedtoo"};
+$query_args .= " --skip-closed"
+       unless $input{"closedtoo"} or $input{"state"} eq "closed";
 
 # Only read the appropriate PR's.
 foreach ("category", "originator", "priority", "class", "responsible",
@@ -509,7 +510,6 @@
 <OPTION VALUE="analyzed">Analyzed</OPTION>
 <OPTION VALUE="feedback">Feedback</OPTION>
 <OPTION VALUE="suspended">Suspended</OPTION>
-<OPTION VALUE="closed">Closed</OPTION>
 </SELECT></TD>
 <TD><B>Sort by</B>:</TD>
 <TD><SELECT NAME="sort">
@@ -519,6 +519,9 @@
 <OPTION VALUE="responsible">Responsible Party</OPTION>
 </SELECT></TD>
 </TR><TR>
+<TD><B>Closed reports too</B>:</TD>
+<TD><INPUT NAME="closedtoo" TYPE=CHECKBOX></TD>
+</TR><TR>
 <!-- We don't use submitter Submitter: -->
 <TD><B>Text in single-line fields</B>:</TD>
 <TD><INPUT TYPE=TEXT NAME="text"></TD>
@@ -529,9 +532,6 @@
 <TD><INPUT TYPE=TEXT NAME="multitext"></TD>
 <TD><B>Originator</B>:</TD>
 <TD><INPUT TYPE=TEXT NAME="originator"></TD>
-</TR><TR>
-<TD><B>Closed reports too</B>:</TD>
-<TD><INPUT NAME="closedtoo" TYPE=CHECKBOX></TD>
 </TR>
 </TABLE>
 <INPUT TYPE="SUBMIT" VALUE=" Query PR's ">


>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message