From owner-svn-ports-all@freebsd.org  Wed Nov 30 16:56:21 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2FE09C5D8AD;
 Wed, 30 Nov 2016 16:56:21 +0000 (UTC) (envelope-from tz@FreeBSD.org)
Received: from toco-domains.de (mail.toco-domains.de
 [IPv6:2a01:4f8:150:50a5::6])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id F0BB61450;
 Wed, 30 Nov 2016 16:56:20 +0000 (UTC) (envelope-from tz@FreeBSD.org)
Received: from [0.0.0.0] (mail.toco-domains.de [IPv6:2a01:4f8:150:50a5::6])
 by toco-domains.de (Postfix) with ESMTPA id 243AD1AAF015;
 Wed, 30 Nov 2016 17:56:19 +0100 (CET)
Subject: Re: svn commit: r427434 - in head/net-im: . pecl-stomp2
To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
References: <201611301617.uAUGHwsP016651@repo.freebsd.org>
 <f3f6852e-ea1e-1338-cb03-4e25b0b8c727@FreeBSD.org>
 <29015284-f5ea-1f84-9fa6-482a223f8c7e@FreeBSD.org>
 <eeb117d2-ae51-fdb5-d0ff-32b0c17c8e39@FreeBSD.org>
From: Torsten Zuehlsdorff <tz@FreeBSD.org>
Message-ID: <ae4a6f8a-b9eb-edea-cd0c-25b5000feedc@FreeBSD.org>
Date: Wed, 30 Nov 2016 17:56:18 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <eeb117d2-ae51-fdb5-d0ff-32b0c17c8e39@FreeBSD.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Nov 2016 16:56:21 -0000



On 30.11.2016 17:38, Mathieu Arnold wrote:
> Le 30/11/2016 à 17:31, Torsten Zuehlsdorff a écrit :
>>
>>
>> On 30.11.2016 17:25, Mathieu Arnold wrote:
>>> Le 30/11/2016 à 17:17, Torsten Zuehlsdorff a écrit :
>>>> +PHP_VER=    70
>>>
>>> This port is not named phpXX-something, you cannot use PHP_VER in it.
>>
>> php70-* ports are nearly all PHP modules. But this is a port of an
>> pecl-extension, which builds just against PHP 7.0 (and 7.1) and become
>> a PHP module. But also build many pecl portsagainst multiple versions
>> of PHP.
>
> If it is not PHP 7.0 specific but also works for PHP 7.1, then you must
> not set PHP_VER.
> It will not build if the default PHP is not 7.0, but it is a good thing,
> because someone installing php 5.6 stuff and then asking for pecl-stomp2
> will get php 7.0 installed and php 5.6 removed.

Done, thanks for the clarification!

>> So what would be a better name? php70-pecl-stomp2? Do i need to
>> duplicate it later into php71-pecl-stomp2? Or shut i just remove the
>> PHP_VER?
>
> Remove the PHP_VER line.
>
> (Side not, PHP 5.5 does not exist any more.)

Dropped it together with PHP_VER.

Greetings,
Torsten