From owner-freebsd-fs@FreeBSD.ORG Thu Aug 5 16:40:12 2010 Return-Path: Delivered-To: freebsd-fs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CCAD2106566C for ; Thu, 5 Aug 2010 16:40:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BAE758FC0C for ; Thu, 5 Aug 2010 16:40:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o75GeC88003676 for ; Thu, 5 Aug 2010 16:40:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o75GeCR1003675; Thu, 5 Aug 2010 16:40:12 GMT (envelope-from gnats) Date: Thu, 5 Aug 2010 16:40:12 GMT Message-Id: <201008051640.o75GeCR1003675@freefall.freebsd.org> To: freebsd-fs@FreeBSD.org From: Andriy Gapon Cc: Subject: Re: kern/148655: [zfs] Booting from a degraded raidz no longer works in 8-STABLE [regression] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Andriy Gapon List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2010 16:40:12 -0000 The following reply was made to PR kern/148655; it has been noted by GNATS. From: Andriy Gapon To: Martin Matuska Cc: bug-followup@FreeBSD.org, am@raisa.eu.org, Pawel Jakub Dawidek , Xin LI Subject: Re: kern/148655: [zfs] Booting from a degraded raidz no longer works in 8-STABLE [regression] Date: Thu, 05 Aug 2010 19:38:17 +0300 on 05/08/2010 19:23 Martin Matuska said the following: > A proposed patch is attached. > > The function vdev_read_phys() (sys/boot/zfs/zfsimpl.c, #325) does call > vdev->v_phys_read() without checking if that function is registered. > > This check should be done in vdev_read_phys before doing anything else. > > vdev_create initializes vdev->v_phys_read as 0 and unavailable vdevs > keep this value. Looks very good. Thanks! -- Andriy Gapon