From nobody Sat Jul 1 21:44:05 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qtm0k0RFFz4jw1w; Sat, 1 Jul 2023 21:44:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qtm0j71X8z45t4; Sat, 1 Jul 2023 21:44:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688247846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J2S4m9exmOs0Bmrxkf7+Y8VlKnA9l0/FlTG1enYMV7M=; b=V0G6woT3KrpL0s9wZ2KHkeMjILx1EH56SWTjl/IAK5EkiQ5YpcXRH/NlICqsmmsXrfa2gZ yFJMj3nYEIaiUZrpnkpd8ZPbxkc0yerVEM2AZqBJ9E4e1GXo1k+vsUJWaIkyX1xgCETWve aOSEbxLTfo3C5cu4vKSQTiRYFqgFzhrfMGUTLyVudsAWkSLA7btA0ZkBnaNDTDVBIxc468 5L+2VHZ8dcND/iC0fddLgFnf0swMubWKp54yia0w76GFATnqQBxMDjWPvHNnFLdsg3APpT WGk3kn/v1Wwb3TMbYVZ0FWcbsOXHBsNci3KDCPJh8Ee255oYtR2FIZXriW4Uhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688247846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J2S4m9exmOs0Bmrxkf7+Y8VlKnA9l0/FlTG1enYMV7M=; b=SJvDEIh7NRA8Y4H3wLJcXu3uhgRFLpwEzBqACBRAltG3HAYjc/+T700u8FAR0I2pGnaQFB Xcoy9D127/OpYkRp8k0DztforFZsxAEQhqohNp4+YkGvh9FFeM1zkLF4THZMjWvjkB2k1d ejB43EF7nyqaDL2EbBZRctn2csmrWQHXUpznThnm2J8ICgXKnZPIfTLhMx1R5yg6irlUId boJ+CmdZ1RP3o0YqdRA8JwzVpDy1Rpr3ozU5qq74KTMNNUzlNwRS1mR5QjI9E+VhnEcEsC GiuBwJNIS8YQJTqleXZKfo4XTssnxY6S8RNsXNgnHj5HlZg4nsaMD4ANd/qRlQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688247846; a=rsa-sha256; cv=none; b=rj79w50ey1/6uexACmkKy8/vAwBbbrkM0D4s78mR4Eg4and8xg65zqX7SXQBHWCwNb9+1f vhmkk6IjfNkqL0FdW0SO0nBy/bRu+fMIN2Ldlal7n0fCVyw65P0I/hmOLPsOu62vMiuqsc k5N8y6ox2HBZvakYhJ+yupn2cCDKPTJzdFbecge+RsdpBa77mAS9i55kdWTG1WBsVDR5Ul D8/l+/kIDWf36Goxp9YPqNU/NSDm2rt6PqNdpAlxFunChKkDuAMpY1mD6c/ZVy5r3OcsEb N0J7kuURmY1DAfMhGTAtbvpPmqDbAcgVZXRjqWvXBt9Rd8RcYQsfwfwb6mdGFg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Qtm0j61yVzhmg; Sat, 1 Jul 2023 21:44:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 361Li5qx001631; Sat, 1 Jul 2023 21:44:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 361Li5io001630; Sat, 1 Jul 2023 21:44:05 GMT (envelope-from git) Date: Sat, 1 Jul 2023 21:44:05 GMT Message-Id: <202307012144.361Li5io001630@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 84deca4d8ca2 - main - libkern: Trim OBE comment from divmoddi routines. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 84deca4d8ca2e188b233a45d503443b17088c788 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=84deca4d8ca2e188b233a45d503443b17088c788 commit 84deca4d8ca2e188b233a45d503443b17088c788 Author: John Baldwin AuthorDate: 2023-07-01 21:43:53 +0000 Commit: John Baldwin CommitDate: 2023-07-01 21:43:53 +0000 libkern: Trim OBE comment from divmoddi routines. -1/2 is defined to be 0 in modern C. Reviewed by: jrtc27 Differential Revision: https://reviews.freebsd.org/D40833 --- sys/libkern/divdi3.c | 1 - sys/libkern/divmoddi4.c | 1 - sys/libkern/moddi3.c | 3 --- 3 files changed, 5 deletions(-) diff --git a/sys/libkern/divdi3.c b/sys/libkern/divdi3.c index 11c34ed72fa0..8e04a81abdba 100644 --- a/sys/libkern/divdi3.c +++ b/sys/libkern/divdi3.c @@ -40,7 +40,6 @@ __FBSDID("$FreeBSD$"); /* * Divide two signed quads. - * ??? if -1/2 should produce -1 on this machine, this code is wrong */ quad_t __divdi3(quad_t a, quad_t b) diff --git a/sys/libkern/divmoddi4.c b/sys/libkern/divmoddi4.c index 7c0a6a690f24..af0013532882 100644 --- a/sys/libkern/divmoddi4.c +++ b/sys/libkern/divmoddi4.c @@ -37,7 +37,6 @@ /* * Divide two signed quads. - * ??? if -1/2 should produce -1 on this machine, this code is wrong */ quad_t __divmoddi4(quad_t a, quad_t b, quad_t *rem) diff --git a/sys/libkern/moddi3.c b/sys/libkern/moddi3.c index 0e93b7d9f6eb..0dbff4bdce89 100644 --- a/sys/libkern/moddi3.c +++ b/sys/libkern/moddi3.c @@ -40,9 +40,6 @@ __FBSDID("$FreeBSD$"); /* * Return remainder after dividing two signed quads. - * - * XXX - * If -1/2 should produce -1 on this machine, this code is wrong. */ quad_t __moddi3(quad_t a, quad_t b)