From owner-freebsd-wireless@FreeBSD.ORG  Tue Aug 16 04:30:07 2011
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DA927106566B
	for <freebsd-wireless@freebsd.org>;
	Tue, 16 Aug 2011 04:30:07 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-yx0-f182.google.com (mail-yx0-f182.google.com
	[209.85.213.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 990E98FC08
	for <freebsd-wireless@freebsd.org>;
	Tue, 16 Aug 2011 04:30:07 +0000 (UTC)
Received: by yxl31 with SMTP id 31so4053492yxl.13
	for <freebsd-wireless@freebsd.org>;
	Mon, 15 Aug 2011 21:30:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:date:message-id:subject:from:to:content-type;
	bh=lofA4K9IQihTUakpFh7RIYxadsTH91yGNd6Za7srMkM=;
	b=PqZkmEIsgJQDylc2UebMfWh99AnNluAYMF8JZF5sDWcqKt5RZA9DlQSiz1focnYc0/
	QBCz+ODrSz4Ft6WzUZaxV3j4H3c8YdrPpu/BSv9Rj5KHMtmwmhg+rVjv5WriunOfyIe4
	e7g75cPCg2VHVh81eRAPwemJDVU10Z/uRSKLg=
MIME-Version: 1.0
Received: by 10.150.217.5 with SMTP id p5mr1882920ybg.329.1313469006745; Mon,
	15 Aug 2011 21:30:06 -0700 (PDT)
Received: by 10.151.10.5 with HTTP; Mon, 15 Aug 2011 21:30:06 -0700 (PDT)
Date: Tue, 16 Aug 2011 12:30:06 +0800
Message-ID: <CAJ-Vmo=k02-NXR_xjb+s4vzgHHrkmNms_Fia7B8Dk_fTaqo4OQ@mail.gmail.com>
From: Adrian Chadd <adrian.chadd@gmail.com>
To: freebsd-wireless@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1
Subject: ieee80211_process_callback() use in drivers
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussions of 802.11 stack,
	tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Aug 2011 04:30:07 -0000

Hi all,

The ieee80211_process_callback() call seems to be used wrong in a couple places.
According to the single (non-HT) use, the manpage, and what looks like
all of the drivers:

0 == OK
non-0 == Failure (either ACK failure, or TX failure)

Bernhard, iwn_ampdu_tx_done() could do with a review, would you please check?

I have a fix to commit to -HEAD to make the BAR TX routines work.

Thanks,


Adrian