From owner-svn-src-all@freebsd.org Thu Feb 1 15:35:34 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4BD9CED8580 for ; Thu, 1 Feb 2018 15:35:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A2A8B72002 for ; Thu, 1 Feb 2018 15:35:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x234.google.com with SMTP id c17so19590288iod.1 for ; Thu, 01 Feb 2018 07:35:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=IMja54nzSvskCgKBu0v0dWXJAz7e+aohBxAus3i1s2w=; b=bjjiQW8TGfIL3sZd8g3L08ENDxk3SmFhTyJ8KTmFIA8UMxTU1uQBbjy18Y4WaVwOdz QnTyjzCsvk6S6zedCekMSlY/xkYRgpDfuXsGkbfm/C0px5EDtZ+1M8seg8fy9bESl5hR KD/Dm6DH3ddhLGHgyil1U++8OenjkuY7wogzG4aK5Gay7VXaxpqAoYU2G3SoH+aQPU+Z h/5+R1JA7GYGPlnTEDE/bOC+vcJBV0NrRwxRFYFvpL2EsMyubbjCg6MBHjAw2+N/pO3W sXhLgNhy9Cs7KQVaVjm2RJstJQIHkkMAIXwiNHFxjIY8CQoQAWyNims5lePQL+V0uHY/ 1iFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=IMja54nzSvskCgKBu0v0dWXJAz7e+aohBxAus3i1s2w=; b=IF/TmPtSKeP6K7tBnG0B/tmvSJi1J8McahAW0e1K7Wlg+kodd/1ibSJCEfoc8vkXWH bn1FztQGgl9U9QQTBulgNVfnbqih/ZKk6ITUd9+2WOSpMohFklh8Lrg3KWztuD9qpL8s iinPsiBjgfisZ3fDN4xx59fqYAYL3n0jnytxxZT/tRiEjZQPJbA4478vOqssU0YEOs4f BpLx82mROijG2gBMKb151qtQoeU4Xc1z2hPqGLUhNrbvwycr7GDL82oicCitihRZTRjb 7DL3UhJ/J/lHintznx6qCE9YX3d5/XfZQlo2APn3PoVXKqI0HR3Swhrh+ZMpwjQ2Lstj zl7w== X-Gm-Message-State: AKwxytez7YfTe+cvMFpREBBTrFCz9G6Yk86MY7QS11bZ/5m6pgRADafb 6FMTs1zTqQGzHku8fQ3US36obkyZMaDNIqJvz+9/gg== X-Google-Smtp-Source: AH8x225pCKhTdgGixvFc9LmhZRZzYSEQi2Od5cEe9zh7aiJc4YgbM4jfVRIhd7Jnjpw1Dd4kbMhtjAKXyipFbFpTQ5s= X-Received: by 10.107.88.12 with SMTP id m12mr35704721iob.136.1517499332956; Thu, 01 Feb 2018 07:35:32 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Thu, 1 Feb 2018 07:35:32 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <201802011532.w11FWmIa088204@repo.freebsd.org> References: <201802011532.w11FWmIa088204@repo.freebsd.org> From: Warner Losh Date: Thu, 1 Feb 2018 08:35:32 -0700 X-Google-Sender-Auth: I7t5PAognWWxfixaUc1m3eTkZNk Message-ID: Subject: Re: svn commit: r328666 - stable/11/sys/dev/nvme To: Alexander Motin Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 15:35:34 -0000 I'd been specifically not MFC'ing the NVME stuff because I wasn't sure that its ABI had jelled yet.... Be sure to merge everything because there's 0 support for anything but the tip of -current for the NVME CAM stuff. Warner On Thu, Feb 1, 2018 at 8:32 AM, Alexander Motin wrote: > Author: mav > Date: Thu Feb 1 15:32:48 2018 > New Revision: 328666 > URL: https://svnweb.freebsd.org/changeset/base/328666 > > Log: > MFC r303466: Kill a few stray debug printfs. > > Modified: > stable/11/sys/dev/nvme/nvme_sim.c > Directory Properties: > stable/11/ (props changed) > > Modified: stable/11/sys/dev/nvme/nvme_sim.c > ============================================================ > ================== > --- stable/11/sys/dev/nvme/nvme_sim.c Thu Feb 1 15:32:14 2018 > (r328665) > +++ stable/11/sys/dev/nvme/nvme_sim.c Thu Feb 1 15:32:48 2018 > (r328666) > @@ -133,8 +133,6 @@ nvme_sim_action(struct cam_sim *sim, union ccb *ccb) > ns = sim2ns(sim); > ctrlr = sim2ctrlr(sim); > > - printf("Sim action: ctrlr %p ns %p\n", ctrlr, ns); > - > mtx_assert(&ctrlr->lock, MA_OWNED); > > switch (ccb->ccb_h.func_code) { > @@ -310,8 +308,6 @@ nvme_sim_new_ns(struct nvme_namespace *ns, void *sc_ar > > sc->s_ns = ns; > > - printf("Our SIM's softc %p ctrlr %p ns %p\n", sc, ctrlr, ns); > - > /* > * XXX this is creating one bus per ns, but it should be one > * XXX target per controller, and one LUN per namespace. > @@ -349,7 +345,6 @@ nvme_sim_new_ns(struct nvme_namespace *ns, void *sc_ar > sc->s_path->device->nvme_cdata = nvme_ctrlr_get_data(ns->ctrlr); > > /* Scan bus */ > - printf("Initiate rescan of the bus\n"); > nvme_sim_rescan_target(ctrlr, sc->s_path); > > mtx_unlock(&ctrlr->lock); > >