From nobody Tue Mar 17 00:24:45 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fZXld3TQYz6VGHc for ; Tue, 17 Mar 2026 00:24:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fZXld1mk3z3xXP for ; Tue, 17 Mar 2026 00:24:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773707085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7p3dMxIwW5apbTNPVLu33zXdZRGa1QHjiNEPrmqqOhg=; b=aKzPQfk7EvF5/8rVpYy7O9gae1fy4G7y0NZA6HLvMW02GbR+OzmS/HCa9iVgIzvogGPW0M gn8MkwGEcFnIDnI8dK++/0VcBqmjx3YdHrGrmA3JU6Lae8CyCsKsWg3zzWOIk16UQUPctW +j3OxwWri6l+e1me9Xb1O0wx/dX9/gt3e90uIQu4oyA/an2XU7krfw5kHtPVHUdCZycsWV 9q/QICzBnqOfr0Pb7u9FmwHwbAel0MhvvJZTUIweeBxG8+ztXx7YQKzNG+Sciw1YgIHeBz m2rM9bvplEBVQI7Y3iqC32Vwt+9NGWqzyjwZMym3Y38JNPwLVgSC6Lod5o+YBg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1773707085; a=rsa-sha256; cv=none; b=EgCnWItRpMZfRwH/9gV/1lYCp2IW9YuPs4DTveyb5LDyyUgAmHLmznbVcI3n9gdtjNp7M8 aFz5OPVvKHGRKCTq5hVOn2/tSeuxCx6RPJQNaFZfeoui37e+Aot8CvMgr8XlbM+cYDEu0Y CoiMt9IXM47m2ilkYO6YyYqg1cUT9FRHhrMD1s+OOABni/Af9V4tmurEHFZvHgLft2Y6zK 8e7pta9IiNLCRCjMqnm13mlIyt+ipxCQM+bQrWjeEIOBBURlGjy56pg04ICwG0i52+fOKq DH0ahe/jKHkXWbfgVueIXLBx8FoQMKQWrcQa99ImpupKDdd13KY0q9pwSvviDA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1773707085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7p3dMxIwW5apbTNPVLu33zXdZRGa1QHjiNEPrmqqOhg=; b=nfC8TyvesCYrP0/DTTfc5816D+kuMHltkxiH14w8AsuGPAaadLVsbbnvU2UI6OYlk9oher sLsICDhxF108WVXxdBuai/S9XsFEzFuYrOGAjfXrYJltUa7YjbmVAnVIJT2mwCWis/L205 TBWYFCr3fXcg5P5LHsJitUbhQHxoryetS5jPzkiV7neUHokg82DOsbPIBcpQbDQfUNIwAo dR6LnO16/sIkkuB9gtGTwa4qnwzyQFpGGYrb/ZYsxIRNlGveWt+25GeygMfyplkxCtbRhs vaG6CY1CM0SAXCBqVDZdSB13vSD8dtnj1r3C/JaGjJt3JcV1mv+6NNaWc3oReg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fZXld0tLtzyc3 for ; Tue, 17 Mar 2026 00:24:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27c8a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 17 Mar 2026 00:24:45 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: 6580d040861d - main - nfs_nfsdserv.c: Fix handling of archive flag for mkdir List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6580d040861dfbf6c630a93cbf41f2a2c7e7b327 Auto-Submitted: auto-generated Date: Tue, 17 Mar 2026 00:24:45 +0000 Message-Id: <69b89f4d.27c8a.49fb75e5@gitrepo.freebsd.org> The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=6580d040861dfbf6c630a93cbf41f2a2c7e7b327 commit 6580d040861dfbf6c630a93cbf41f2a2c7e7b327 Author: Rick Macklem AuthorDate: 2026-03-16 23:22:37 +0000 Commit: Rick Macklem CommitDate: 2026-03-16 23:22:37 +0000 nfs_nfsdserv.c: Fix handling of archive flag for mkdir An NFSv4.1/4.2 client can set/clear the archive, hidden and system flags when creating non-regular files, such as directories. Without this patch, the setting of va_flags causes an EPERM failure, since they are specified for VOP_MKDIR(), VOP_MKNOD() and VOP_SYMLINK(). This patch sets va_flags == VNOVAL for the above VOP_xxx() calls and then sets/clears the flags after creation, which fixes the problem. This bug only affects the Windows NFSv4.1/4.2 client. PR: 293691 Tested by: Dan Shelton MFC after: 2 weeks --- sys/fs/nfsserver/nfs_nfsdserv.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/sys/fs/nfsserver/nfs_nfsdserv.c b/sys/fs/nfsserver/nfs_nfsdserv.c index b5f5b9bec9fc..b5c7f4743be0 100644 --- a/sys/fs/nfsserver/nfs_nfsdserv.c +++ b/sys/fs/nfsserver/nfs_nfsdserv.c @@ -1438,7 +1438,7 @@ nfsrvd_mknod(struct nfsrv_descript *nd, __unused int isdgram, vnode_t vp, dirp = NULL; nfsattrbit_t attrbits; char *bufp = NULL, *pathcp = NULL; - u_long *hashp, cnflags; + u_long *hashp, cnflags, setflags; NFSACL_T *aclp = NULL, *daclp = NULL; struct thread *p = curthread; @@ -1605,9 +1605,13 @@ nfsrvd_mknod(struct nfsrv_descript *nd, __unused int isdgram, } } + /* For NFSv4, set na_flags via nfsrv_fixattr(). */ + setflags = nva.na_flags; + nva.na_flags = VNOVAL; nd->nd_repstat = nfsvno_mknod(&named, &nva, nd->nd_cred, p); if (!nd->nd_repstat) { vp = named.ni_vp; + nva.na_flags = setflags; nfsrv_fixattr(nd, vp, &nva, aclp, daclp, p, &attrbits, false); nd->nd_repstat = nfsvno_getfh(vp, fhp, p); if ((nd->nd_flag & ND_NFSV3) && !nd->nd_repstat) @@ -2115,10 +2119,14 @@ nfsrvd_symlinksub(struct nfsrv_descript *nd, struct nameidata *ndp, int pathlen) { u_int32_t *tl; + u_long setflags; + setflags = nvap->na_flags; + nvap->na_flags = (u_long)VNOVAL; nd->nd_repstat = nfsvno_symlink(ndp, nvap, pathcp, pathlen, !(nd->nd_flag & ND_NFSV2), nd->nd_saveduid, nd->nd_cred, p, exp); if (!nd->nd_repstat && !(nd->nd_flag & ND_NFSV2)) { + nvap->na_flags = setflags; nfsrv_fixattr(nd, ndp->ni_vp, nvap, aclp, NULL, p, attrbitp, false); if (nd->nd_flag & ND_NFSV3) { @@ -2249,12 +2257,16 @@ nfsrvd_mkdirsub(struct nfsrv_descript *nd, struct nameidata *ndp, { vnode_t vp; u_int32_t *tl; + u_long setflags; + setflags = nvap->na_flags; + nvap->na_flags = (u_long)VNOVAL; NFSVNO_SETATTRVAL(nvap, type, VDIR); nd->nd_repstat = nfsvno_mkdir(ndp, nvap, nd->nd_saveduid, nd->nd_cred, p, exp); if (!nd->nd_repstat) { vp = ndp->ni_vp; + nvap->na_flags = setflags; nfsrv_fixattr(nd, vp, nvap, aclp, daclp, p, attrbitp, false); nd->nd_repstat = nfsvno_getfh(vp, fhp, p); if (!(nd->nd_flag & ND_NFSV4) && !nd->nd_repstat)