From owner-freebsd-current@FreeBSD.ORG Sat Jun 23 20:54:21 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9FDC416A41F for ; Sat, 23 Jun 2007 20:54:21 +0000 (UTC) (envelope-from caelian@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.172]) by mx1.freebsd.org (Postfix) with ESMTP id 16D4F13C487 for ; Sat, 23 Jun 2007 20:54:20 +0000 (UTC) (envelope-from caelian@gmail.com) Received: by ug-out-1314.google.com with SMTP id u2so1148469uge for ; Sat, 23 Jun 2007 13:54:19 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:subject:from:to:cc:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=DihTRKMv07HPu+jtj0eAFx8ZexTc04WFZ258sezwylBwRp+nlg18ZwIUeC6tUVzEGJJUo32e43/5bz91ZJxoS8cxuXTM70zLOSf79a+1G1AQsNDiSF2QfyItlCu8XAzaZ5kUmAJygPP1kOVv+BxixESoeIvqVYNcP5X421Z+zDg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:subject:from:to:cc:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=oluP1QFAn3BZE2cBQ9ojxstpexs526YKqQsmOBbqUBWFcTxxh1oFNGb7nCW7DwWzKlsrk4QaCPkJ/hzz59QsfCXp+oJwFbO/cmXdhfcLmqcvM/z4bFznqXf40bXSripUZyYzZsz4jgxMOagdpuklYU7/EOqaN6uEkBSECajWT6Q= Received: by 10.66.220.12 with SMTP id s12mr3845568ugg.1182632059832; Sat, 23 Jun 2007 13:54:19 -0700 (PDT) Received: from ?192.168.0.23? ( [87.166.67.65]) by mx.google.com with ESMTP id r57sm3644043ugr.2007.06.23.13.54.19 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 23 Jun 2007 13:54:19 -0700 (PDT) From: Pascal Hofstee To: =?ISO-8859-1?Q?S=F8ren?= Schmidt Content-Type: text/plain Date: Sat, 23 Jun 2007 22:54:18 +0200 Message-Id: <1182632058.1217.3.camel@worf> Mime-Version: 1.0 X-Mailer: Evolution 2.10.2 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: current@freebsd.org Subject: recent USB changes break building of atausb module X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2007 20:54:21 -0000 Hi, I just updated to a fresh current today to notice that with the recent slew of commits to the usb subsystem, the atausb module no longer compiles. cc -O2 -fno-strict-aliasing -pipe -march=athlon-mp -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -c /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:151: warning: data definition has no type or storage class /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:151: warning: type defaults to 'int' in declaration of 'USB_DECLARE_DRIVER' /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:151: warning: parameter names (without types) in function declaration /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:152: error: 'atausb_driver' undeclared here (not in a function) /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:152: error: 'atausb_devclass' undeclared here (not in a function) /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c: In function 'atausb_attach': /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:278: warning: implicit declaration of function 'atausb_detach' /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:278: warning: nested extern declaration of 'atausb_detach' /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c: At top level: /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:353: error: static declaration of 'atausb_detach' follows non-static declaration /usr/src/sys/modules/ata/atausb/../../../dev/ata/ata-usb.c:278: error: previous implicit declaration of 'atausb_detach' was here *** Error code 1 I know it's not exactly critical as atausb is not built on default but would appreciate it if somebody could have a closer look at this. -- Pascal Hofstee