From nobody Mon Dec 16 14:45:03 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YBjQl6Dhpz5hW32; Mon, 16 Dec 2024 14:45:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YBjQl4JR2z4bqT; Mon, 16 Dec 2024 14:45:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734360303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/PjNT42VezlWyi5yFYd3WIEJ3eJ6GZL0ejfmwXk3p4c=; b=ED6/QXOrZ2MKUW6neP9BRnV0wYVyMIBu65T7qgZY4zjm1SYPgC8ovG3rklLG7FoUB+mLVF Qi0m1MOw6QUvZgWfB/8xzEGFHvrQTZ8BO+vHl6ycnJLM0t5SEGQjOTgYTxI/DEiDxUsVeI 2W0/LOZCCoVxJSIIplTl6+nZ/+4S33njhdyZKxOy9XDq4SMgiLjjw45P3U42ianXErM2p/ qXN0HoWFE8qOdnbkImjUBNGA8tmuvxydfgxc8dfkwHsM6KH1Ku/kiZEKDEc2RgwW/K43Ym j1k9BWfhx8hS4mjBIz7uoL7j7nJF6uzYk7+CkWsF6a1nPtaDJ4duK8fFGaSlTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734360303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/PjNT42VezlWyi5yFYd3WIEJ3eJ6GZL0ejfmwXk3p4c=; b=wYvN9dfGZ7zcsr0KSVhvFa4NVKkPOJNfaC542sBqGO5vIUriYp/8pfKLZpO23Zm9l+BBln eBa2i/0hwJki3Bqvo4q++4GUH7VHjnF9EDmUlMgJJ6D7IQ4onrvJvE1HbLHktf5hyqGKy+ HXJrK952CipHeG3PMCx1omxpZUXx7pW1wNyg/1xLleUkT02JAhnNzgwwjm3wd2jvPzljk9 fV+QsZ2XC0Xbe+bVOEuynK12zmLfQ0e32c+p2Y6NMMyZtL6N+A5tv2/wwBsJOU9D5e17jN aroA1ipaD1nmay78I9BV5m1kgsRxdw5Kn6FO0ZfQnGW2KvA5ITLCGkexVvLb0g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1734360303; a=rsa-sha256; cv=none; b=iknYvCe3jRoykHClKku2UAdTyuBtYS1cjoIDeeLdEInfcrdRiEbXVu4TBxmDoAWnl2spp1 cuPDPsGfMqOvpUJqPYb1DzD5O9V2zD9PVk9MgCK5f6eKO1166uQBjIhGoY4XES0a35Eoae NCmjj1JnzH0X6TnmnSwBh6QOnOgYd+SjBNLnYKtklt+R8V+crKM3KLwgxyCpy8dFJmP1qv ITP8DN1vXx2QmFemeGkqDF8QshiGjqe8A6Tgov/+r78S61ypzjOEORUgrAkbvxy9e2CCz9 MqEsMOVLMcMLYBGdVYYj7OtuS4xDSAmE8N3FS6AucxcNWB2juslee+1BdWDqqw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YBjQl3pBVzxnG; Mon, 16 Dec 2024 14:45:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4BGEj3mN050943; Mon, 16 Dec 2024 14:45:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4BGEj3ln050940; Mon, 16 Dec 2024 14:45:03 GMT (envelope-from git) Date: Mon, 16 Dec 2024 14:45:03 GMT Message-Id: <202412161445.4BGEj3ln050940@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 4a26b63145a5 - main - osd: Constify signature of osd_register() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4a26b63145a5e18610aa9050262e3b4f75aa7117 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=4a26b63145a5e18610aa9050262e3b4f75aa7117 commit 4a26b63145a5e18610aa9050262e3b4f75aa7117 Author: Olivier Certner AuthorDate: 2024-07-01 17:10:47 +0000 Commit: Olivier Certner CommitDate: 2024-12-16 14:42:20 +0000 osd: Constify signature of osd_register() This makes it clear that 'methods' (if not NULL) points to an array that won't be modified. Internally, this array is indeed copied into the given OSD type's larger array of all methods for all slots. Reviewed by: jamie Approved by: markj (mentor) MFC after: 5 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46886 --- share/man/man9/osd.9 | 4 ++-- sys/kern/kern_osd.c | 2 +- sys/sys/osd.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/share/man/man9/osd.9 b/share/man/man9/osd.9 index 95547f5211c2..5e0e482914c3 100644 --- a/share/man/man9/osd.9 +++ b/share/man/man9/osd.9 @@ -23,7 +23,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd April 26, 2016 +.Dd October 07, 2024 .Dt OSD 9 .Os .Sh NAME @@ -49,7 +49,7 @@ .Fo osd_register .Fa "u_int type" .Fa "osd_destructor_t destructor" -.Fa "osd_method_t *methods" +.Fa "const osd_method_t *methods" .Fc .Ft void .Fo osd_deregister diff --git a/sys/kern/kern_osd.c b/sys/kern/kern_osd.c index dcd80a948ea7..93809ccab8e5 100644 --- a/sys/kern/kern_osd.c +++ b/sys/kern/kern_osd.c @@ -90,7 +90,7 @@ osd_default_destructor(void *value __unused) } int -osd_register(u_int type, osd_destructor_t destructor, osd_method_t *methods) +osd_register(u_int type, osd_destructor_t destructor, const osd_method_t *methods) { void *newptr; u_int i, m; diff --git a/sys/sys/osd.h b/sys/sys/osd.h index 498cad5064f9..5d59ce5a3d9a 100644 --- a/sys/sys/osd.h +++ b/sys/sys/osd.h @@ -55,7 +55,7 @@ typedef void (*osd_destructor_t)(void *value); typedef int (*osd_method_t)(void *obj, void *data); int osd_register(u_int type, osd_destructor_t destructor, - osd_method_t *methods); + const osd_method_t *methods); void osd_deregister(u_int type, u_int slot); int osd_set(u_int type, struct osd *osd, u_int slot, void *value);