Date: Mon, 24 Apr 2023 22:18:01 +0200 From: Moin Rahman <bofh@freebsd.org> To: Antoine Brodin <antoine@freebsd.org> Cc: "<ports-committers@freebsd.org>" <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 9f5034f55a47 - main - Mk/Uses/php.mk: Refactor Message-ID: <F288BA3E-070A-4D83-A445-CB450B938024@freebsd.org> In-Reply-To: <CAALwa8k6J%2Bc3KWuc1o_h9ZLCUf9xiZRpU4EMMM0MyVhzKfUO%2Bw@mail.gmail.com> References: <202304242001.33OK19wU009301@gitrepo.freebsd.org> <CAALwa8k6J%2Bc3KWuc1o_h9ZLCUf9xiZRpU4EMMM0MyVhzKfUO%2Bw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_B916EEDD-B341-4C42-8CD5-57F4E7EDCD63 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Apr 24, 2023, at 10:16 PM, Antoine Brodin <antoine@freebsd.org> = wrote: >=20 > On Mon, Apr 24, 2023 at 8:01=E2=80=AFPM Muhammad Moinur Rahman = <bofh@freebsd.org <mailto:bofh@freebsd.org>> wrote: >>=20 >> The branch main has been updated by bofh: >>=20 >> URL: = https://cgit.FreeBSD.org/ports/commit/?id=3D9f5034f55a47591288167cd49fe4bb= 963143caed >>=20 >> commit 9f5034f55a47591288167cd49fe4bb963143caed >> Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> >> AuthorDate: 2023-04-24 19:59:31 +0000 >> Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> >> CommitDate: 2023-04-24 20:01:01 +0000 >>=20 >> Mk/Uses/php.mk: Refactor >>=20 >> - Replace old USE_APACHE_RUN with USES=3Dapache:run >> - Prior to php8.0 there was a check for the required libname which >> contained the version number of php. Remove the conditional. >>=20 >> Sponsored by: Bounce Experts >> --- >> Mk/Uses/php.mk | 7 +------ >> 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > Hi, >=20 > Overriding USES doesn't look good. > Maybe it should be something like this instead: > apache_ARGS?=3Drun > .include "${USESDIR}/apache.mk" >=20 > Antoine Ouch. Let me rerun a test and update. Kind regards, Moin= --Apple-Mail=_B916EEDD-B341-4C42-8CD5-57F4E7EDCD63 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On Apr 24, 2023, at 10:16 PM, Antoine Brodin <<a = href=3D"mailto:antoine@freebsd.org" class=3D"">antoine@freebsd.org</a>>= wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><meta= charset=3D"UTF-8" class=3D""><span style=3D"caret-color: rgb(0, 0, 0); = font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; = font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none; float: none; = display: inline !important;" class=3D"">On Mon, Apr 24, 2023 at = 8:01=E2=80=AFPM Muhammad Moinur Rahman <</span><a = href=3D"mailto:bofh@freebsd.org" style=3D"font-family: = FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = orphans: auto; text-align: start; text-indent: 0px; text-transform: = none; white-space: normal; widows: auto; word-spacing: 0px; = -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" = class=3D"">bofh@freebsd.org</a><span style=3D"caret-color: rgb(0, 0, 0); = font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; = font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none; float: none; = display: inline !important;" class=3D"">> wrote:</span><br = style=3D"caret-color: rgb(0, 0, 0); font-family: = FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""><blockquote type=3D"cite" = style=3D"font-family: FiraCodeNerdFontCompleteM-Regular; font-size: = 11px; font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; orphans: auto; text-align: start; text-indent: = 0px; text-transform: none; white-space: normal; widows: auto; = word-spacing: 0px; -webkit-text-size-adjust: auto; = -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D""><br = class=3D"">The branch main has been updated by bofh:<br class=3D""><br = class=3D"">URL: <a = href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D9f5034f55a47591288167c= d49fe4bb963143caed" = class=3D"">https://cgit.FreeBSD.org/ports/commit/?id=3D9f5034f55a475912881= 67cd49fe4bb963143caed</a><br class=3D""><br class=3D"">commit = 9f5034f55a47591288167cd49fe4bb963143caed<br class=3D"">Author: = Muhammad Moinur Rahman <<a = href=3D"mailto:bofh@FreeBSD.org" class=3D"">bofh@FreeBSD.org</a>><br = class=3D"">AuthorDate: 2023-04-24 19:59:31 +0000<br class=3D"">Commit: = Muhammad Moinur Rahman <<a = href=3D"mailto:bofh@FreeBSD.org" class=3D"">bofh@FreeBSD.org</a>><br = class=3D"">CommitDate: 2023-04-24 20:01:01 +0000<br class=3D""><br = class=3D""> Mk/Uses/php.mk: Refactor<br class=3D""><br = class=3D""> - Replace old USE_APACHE_RUN with = USES=3Dapache:run<br class=3D""> - Prior to php8.0 = there was a check for the required libname which<br = class=3D""> contained the version number of = php. Remove the conditional.<br class=3D""><br = class=3D""> Sponsored by: Bounce Experts<br = class=3D"">---<br class=3D"">Mk/Uses/php.mk | 7 +------<br class=3D"">1 = file changed, 1 insertion(+), 6 deletions(-)<br = class=3D""></blockquote><br style=3D"caret-color: rgb(0, 0, 0); = font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; = font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D""><span = style=3D"caret-color: rgb(0, 0, 0); font-family: = FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;" = class=3D"">Hi,</span><br style=3D"caret-color: rgb(0, 0, 0); = font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; = font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D""><br = style=3D"caret-color: rgb(0, 0, 0); font-family: = FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, = 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; = font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none; float: none; = display: inline !important;" class=3D"">Overriding USES doesn't look = good.</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: = FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, = 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; = font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none; float: none; = display: inline !important;" class=3D"">Maybe it should be something = like this instead:</span><br style=3D"caret-color: rgb(0, 0, 0); = font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; = font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D""><span = style=3D"caret-color: rgb(0, 0, 0); font-family: = FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;" = class=3D"">apache_ARGS?=3Drun</span><br style=3D"caret-color: rgb(0, 0, = 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; = font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none;" class=3D""><span = style=3D"caret-color: rgb(0, 0, 0); font-family: = FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none; float: none; display: inline !important;" = class=3D"">.include "${USESDIR}/apache.mk"</span><br style=3D"caret-color:= rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; = font-size: 11px; font-style: normal; font-variant-caps: normal; = font-weight: 400; letter-spacing: normal; text-align: start; = text-indent: 0px; text-transform: none; white-space: normal; = word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: = none;" class=3D""><br style=3D"caret-color: rgb(0, 0, 0); font-family: = FiraCodeNerdFontCompleteM-Regular; font-size: 11px; font-style: normal; = font-variant-caps: normal; font-weight: 400; letter-spacing: normal; = text-align: start; text-indent: 0px; text-transform: none; white-space: = normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; = text-decoration: none;" class=3D""><span style=3D"caret-color: rgb(0, 0, = 0); font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px; = font-style: normal; font-variant-caps: normal; font-weight: 400; = letter-spacing: normal; text-align: start; text-indent: 0px; = text-transform: none; white-space: normal; word-spacing: 0px; = -webkit-text-stroke-width: 0px; text-decoration: none; float: none; = display: inline !important;" = class=3D"">Antoine</span></div></blockquote></div><br class=3D""><div = class=3D""><br class=3D""></div><div class=3D"">Ouch. Let me rerun a = test and update.</div><div class=3D""><br class=3D""></div><div = class=3D"">Kind regards,</div><div class=3D"">Moin</div></body></html>= --Apple-Mail=_B916EEDD-B341-4C42-8CD5-57F4E7EDCD63--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F288BA3E-070A-4D83-A445-CB450B938024>